From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org, Steven French <sfrench@us.ibm.com>
Subject: Re: [PATCH] mark address_space_operations const
Date: Fri, 12 May 2006 04:20:23 -0700 [thread overview]
Message-ID: <20060512042023.2dd484f4.akpm@osdl.org> (raw)
In-Reply-To: <20060503131836.GA6991@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
>
> Same as with already do with the file operations:
> keep them in .rodata and prevents people from doing runtime patching.
It would occasionally be nice to be the second person to compile something.
fs/cifs/inode.c: In function `cifs_get_inode_info_unix':
fs/cifs/inode.c:187: warning: assignment of read-only member `readpages'
fs/cifs/inode.c: In function `cifs_get_inode_info':
fs/cifs/inode.c:525: warning: assignment of read-only member `readpages'
Steve, you should have separate sets of a_ops and select the appropriate
one for inode->i_data.a_ops, rather than scribbling on cifs_addr_ops.
next prev parent reply other threads:[~2006-05-12 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-03 13:18 [PATCH] mark address_space_operations const Christoph Hellwig
2006-05-09 5:30 ` Prasanna S Panchamukhi
2006-05-09 5:56 ` Greg KH
2006-05-09 7:24 ` Prasanna S Panchamukhi
2006-05-09 9:13 ` Christoph Hellwig
2006-05-12 11:20 ` Andrew Morton [this message]
2006-05-12 18:35 ` [PATCH] CIFS: Do not overwrite aops elements Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060512042023.2dd484f4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sfrench@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).