From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] mark address_space_operations const Date: Fri, 12 May 2006 04:20:23 -0700 Message-ID: <20060512042023.2dd484f4.akpm@osdl.org> References: <20060503131836.GA6991@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Steven French Return-path: Received: from smtp.osdl.org ([65.172.181.4]:40419 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751204AbWELLXZ (ORCPT ); Fri, 12 May 2006 07:23:25 -0400 To: Christoph Hellwig In-Reply-To: <20060503131836.GA6991@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Christoph Hellwig wrote: > > Same as with already do with the file operations: > keep them in .rodata and prevents people from doing runtime patching. It would occasionally be nice to be the second person to compile something. fs/cifs/inode.c: In function `cifs_get_inode_info_unix': fs/cifs/inode.c:187: warning: assignment of read-only member `readpages' fs/cifs/inode.c: In function `cifs_get_inode_info': fs/cifs/inode.c:525: warning: assignment of read-only member `readpages' Steve, you should have separate sets of a_ops and select the appropriate one for inode->i_data.a_ops, rather than scribbling on cifs_addr_ops.