From: Greg KH <greg@kroah.com>
To: Michael Halcrow <lkml@halcrow.us>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Andrew Morton <akpm@osdl.org>,
michael.craig.thompson@gmail.com, phillip@hellewell.homeip.net,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@ftp.linux.org.uk, mhalcrow@us.ibm.com, mcthomps@us.ibm.com,
toml@us.ibm.com, yoder1@us.ibm.com, jmorris@namei.org,
sct@redhat.com, ezk@cs.sunysb.edu, dhowells@redhat.com
Subject: Re: [PATCH 0/13: eCryptfs] eCryptfs Patch Set
Date: Sat, 13 May 2006 20:54:22 -0700 [thread overview]
Message-ID: <20060514035422.GA6451@kroah.com> (raw)
In-Reply-To: <20060514034346.GA4427@halcrow.us>
On Sat, May 13, 2006 at 10:43:46PM -0500, Michael Halcrow wrote:
> On Sun, May 14, 2006 at 01:26:55PM +1000, Nick Piggin wrote:
> > Compiling at each step is better than not. But my main point is
> > that it is superfluously broken into multiple patches.
>
> This comment is from about a year ago, so it probably has fallen off
> the radar:
>
> At 2005-06-02 14:51:54, Greg K-H wrote:
> > On Thu, Jun 02, 2005 at 07:32:19AM -0500, Michael Halcrow wrote:
> > > What sort of
> > > logical chunks would you consider to be appropriate? Separate patches
> > > for each file (inode.c, file.c, super.c, etc.), which represent sets
> > > of functions for each major VFS object?
> >
> > Yes.
Yes, but don't break the build along the way.
thanks,
greg k-h
next prev parent reply other threads:[~2006-05-14 3:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-13 3:37 [PATCH 0/13: eCryptfs] eCryptfs Patch Set Phillip Hellewell
2006-05-13 3:40 ` [PATCH 1/13: eCryptfs] fs/Makefile and fs/Kconfig Phillip Hellewell
2006-05-13 8:51 ` Jan-Benedict Glaw
2006-05-13 3:41 ` [PATCH 2/13: eCryptfs] Documentation Phillip Hellewell
2006-05-13 3:42 ` [PATCH 3/13: eCryptfs] Makefile Phillip Hellewell
2006-05-13 3:42 ` [PATCH 4/13: eCryptfs] Main module functions Phillip Hellewell
2006-05-13 3:43 ` [PATCH 5/13: eCryptfs] Header declarations Phillip Hellewell
2006-05-13 3:44 ` [PATCH 6/13: eCryptfs] Superblock operations Phillip Hellewell
2006-05-13 3:45 ` [PATCH 7/13: eCryptfs] Dentry operations Phillip Hellewell
2006-05-13 3:45 ` [PATCH 8/13: eCryptfs] File operations Phillip Hellewell
2006-05-13 3:46 ` [PATCH 9/13: eCryptfs] Inode operations Phillip Hellewell
2006-05-13 3:47 ` [PATCH 10/13: eCryptfs] Mmap operations Phillip Hellewell
2006-06-28 14:16 ` Pekka Enberg
2006-06-28 15:02 ` Michael Halcrow
2006-05-13 3:47 ` [PATCH 11/13: eCryptfs] Keystore Phillip Hellewell
2006-05-13 3:48 ` [PATCH 12/13: eCryptfs] Crypto functions Phillip Hellewell
2006-05-13 3:49 ` [PATCH 13/13: eCryptfs] Debug functions Phillip Hellewell
2006-05-13 4:21 ` [PATCH 0/13: eCryptfs] eCryptfs Patch Set Nick Piggin
2006-05-13 16:21 ` Michael Thompson
2006-05-14 2:59 ` Nick Piggin
2006-05-14 3:13 ` Andrew Morton
2006-05-14 3:26 ` Nick Piggin
2006-05-14 3:43 ` Michael Halcrow
2006-05-14 3:54 ` Greg KH [this message]
2006-05-15 10:17 ` David Howells
2006-05-15 10:59 ` Andrew Morton
2006-05-20 9:57 ` Christoph Hellwig
2006-06-01 20:47 ` Michael Halcrow
2006-07-07 10:01 ` Christoph Hellwig
2006-07-07 11:54 ` Christoph Hellwig
2006-07-07 12:23 ` Pekka Enberg
2006-07-07 17:22 ` David Quigley
2006-07-08 17:21 ` Christoph Hellwig
2006-07-08 21:22 ` Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060514035422.GA6451@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=ezk@cs.sunysb.edu \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@halcrow.us \
--cc=mcthomps@us.ibm.com \
--cc=mhalcrow@us.ibm.com \
--cc=michael.craig.thompson@gmail.com \
--cc=nickpiggin@yahoo.com.au \
--cc=phillip@hellewell.homeip.net \
--cc=sct@redhat.com \
--cc=toml@us.ibm.com \
--cc=viro@ftp.linux.org.uk \
--cc=yoder1@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).