From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Blunck Subject: Re: [patch 4/5] vfs: per superblock dentry stats Date: Mon, 29 May 2006 11:43:26 +0200 Message-ID: <20060529094326.GF21024@hasse.suse.de> References: <20060526110655.197949000@suse.de>> <20060526110802.852609000@suse.de> <20060529022401.GT8069029@melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk Return-path: Received: from cantor2.suse.de ([195.135.220.15]:19923 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1750816AbWE2Jn2 (ORCPT ); Mon, 29 May 2006 05:43:28 -0400 To: David Chinner Content-Disposition: inline In-Reply-To: <20060529022401.GT8069029@melbourne.sgi.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, May 29, David Chinner wrote: > > -struct dentry_stat_t { > > +struct dentry_stat { > > int nr_dentry; > > int nr_unused; > > - int age_limit; /* age in seconds */ > > - int want_pages; /* pages requested by system */ > > - int dummy[2]; > > + int age_limit; /* age in seconds */ > > }; > > that changes the size of the structure from 6*sizeof(int) to > 3*sizeof(int).... > > > Index: work-2.6/kernel/sysctl.c > > =================================================================== > > --- work-2.6.orig/kernel/sysctl.c > > +++ work-2.6/kernel/sysctl.c > > @@ -958,7 +958,7 @@ static ctl_table fs_table[] = { > > { > > .ctl_name = FS_DENTRY, > > .procname = "dentry-state", > > - .data = &dentry_stat, > > + .data = &global_dentry_stat, > > .maxlen = 6*sizeof(int), > > With the above change, maxlen = 3*sizeof(int). > > Given that's a userspace visible change, should the above structure > change use a "int dummy[3];" to keep the global structure and userspace > export the same? Hmm, probably you are right. I'll change this. Jan