From: Al Viro <viro@ftp.linux.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: akpm@osdl.org, aviro@redhat.com, linux-kernel@vger.kernel.org,
nfsv4@linux-nfs.org, trond.myklebust@fys.uio.no,
torvalds@osdl.org, linux-cachefs@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 01/14] NFS: Permit filesystem to override root dentry on mount [try #10]
Date: Tue, 30 May 2006 11:45:32 +0100 [thread overview]
Message-ID: <20060530104532.GW27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20060519154644.11791.72373.stgit@warthog.cambridge.redhat.com>
On Fri, May 19, 2006 at 04:46:45PM +0100, David Howells wrote:
> informative error value to report). Call it foo_fill_super(). Now declare
>
> -struct super_block foo_get_sb(struct file_system_type *fs_type,
> - int flags, const char *dev_name, void *data)
> +int foo_get_sb(struct file_system_type *fs_type,
> + int flags, const char *dev_name, void *data, struct vfsmount *mnt)
> {
> - return get_sb_bdev(fs_type, flags, dev_name, data, ext2_fill_super);
> + return get_sb_bdev(fs_type, flags, dev_name, data, ext2_fill_super,
> + mnt);
> }
BTW, s/ext2_fill_super/foo_fill_super/, while we are at it...
> + BUG_ON(!mnt->mnt_sb);
> + BUG_ON(!mnt->mnt_sb->s_root);
> + BUG_ON(!mnt->mnt_root);
FWIW, I'm not sure it's needed. We do
> + up_write(&mnt->mnt_sb->s_umount);
soon enough and it will catch all likely breakage without cluttering
the code with BUG_ON(). Other than that, no objections.
next prev parent reply other threads:[~2006-05-30 10:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-19 15:46 [PATCH 00/14] Permit filesystem local caching and NFS superblock sharing [try #10] David Howells
2006-05-19 15:46 ` [PATCH 01/14] NFS: Permit filesystem to override root dentry on mount " David Howells
2006-05-30 10:45 ` Al Viro [this message]
2006-05-19 15:46 ` [PATCH 02/14] NFS: Permit filesystem to perform statfs with a known root dentry " David Howells
2006-05-19 15:46 ` [PATCH 03/14] NFS: Abstract out namespace initialisation " David Howells
2006-05-30 10:35 ` Al Viro
2006-05-30 10:51 ` David Howells
2006-05-19 15:46 ` [PATCH 04/14] NFS: Add dentry materialisation op " David Howells
2006-05-19 15:46 ` [PATCH 05/14] NFS: Split fs/nfs/inode.c into inode, superblock and namespace bits " David Howells
2006-05-19 15:46 ` [PATCH 06/14] NFS: Share NFS superblocks per-protocol per-server per-FSID " David Howells
2006-05-19 15:46 ` [PATCH 07/14] FS-Cache: Provide a filesystem-specific sync'able page bit " David Howells
2006-05-19 15:47 ` [PATCH 08/14] FS-Cache: Add notification of page becoming writable to VMA ops " David Howells
2006-05-19 15:47 ` [PATCH 09/14] FS-Cache: Avoid ENFILE checking for kernel-specific open files " David Howells
2006-05-19 15:47 ` [PATCH 10/14] FS-Cache: Generic filesystem caching facility " David Howells
2006-05-19 15:47 ` [PATCH 11/14] FS-Cache: Release page->private in failed readahead " David Howells
2006-05-19 15:47 ` [PATCH 12/14] FS-Cache: Make kAFS use FS-Cache " David Howells
2006-05-19 15:47 ` [PATCH 13/14] FS-Cache: CacheFiles: A cache that backs onto a mounted filesystem " David Howells
2006-05-19 15:47 ` [PATCH 14/14] NFS: Use local caching " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060530104532.GW27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=aviro@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).