From: David Chinner <dgc@sgi.com>
To: Jan Blunck <jblunck@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Balbir Singh <balbir@in.ibm.com>
Subject: Re: [PATCH] Per-superblock unused dentry LRU lists V3
Date: Wed, 31 May 2006 10:40:22 +1000 [thread overview]
Message-ID: <20060531004022.GM8069029@melbourne.sgi.com> (raw)
In-Reply-To: <20060530150438.GB4377@hasse.suse.de>
On Tue, May 30, 2006 at 05:04:38PM +0200, Jan Blunck wrote:
> > David Chinner <dgc@sgi.com> wrote:
> > -
> > void shrink_dcache_sb(struct super_block * sb)
> > {
....
> > + __shrink_dcache_sb(sb, &sb->s_dentry_lru_nr, 0);
> > }
>
> This doesn't prune all the dentries on the unused list. The parents of the
> pruned dentries are added to the unused list. Therefore just shrinking
> sb->s_dentry_lru_nr dentries isn't enough.
Yes, you are right, Jan. I'm surprised I didn't see problems due to this.
The original patch got this right by shrinking in this case until the list
was empty. I'll wrap this one in a while loop...
Cheers,
Dave.
--
Dave Chinner
R&D Software Enginner
SGI Australian Software Group
next prev parent reply other threads:[~2006-05-31 0:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-26 2:35 [PATCH] Per-superblock unused dentry LRU lists V3 David Chinner
2006-05-26 3:01 ` Andrew Morton
2006-05-26 3:49 ` David Chinner
[not found] ` <4de7f8a60605300753j3b1e257u3849b72e7bc4d100@mail.gmail.com>
2006-05-30 15:04 ` Jan Blunck
2006-05-31 0:40 ` David Chinner [this message]
2006-05-31 2:58 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060531004022.GM8069029@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=balbir@in.ibm.com \
--cc=jblunck@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).