* vfsmount_lock in __d_path()
[not found] <200603041038.BCC57442.GCOSMJNFtPXSFOFTFL@I-love.SAKURA.ne.jp>
@ 2006-05-31 11:14 ` Tetsuo Handa
2006-05-31 12:20 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Tetsuo Handa @ 2006-05-31 11:14 UTC (permalink / raw)
To: linux-fsdevel
Hello.
I posted this message three months ago at kernelnewbies-ml, but no answer.
Now reposting at fsdevel-ml.
> In the function __d_path() at http://lxr.linux.no/source/fs/dcache.c#L1354 ,
> "vfsmnt->mnt_parent" "vfsmnt->mnt_mountpoint" "vfsmnt->mnt_parent"
> are protected by spin_lock(&vfsmount_lock), while "vfsmnt->mnt_root" is not.
>
> In the function do_move_mount() at http://lxr.linux.no/source/fs/namespace.c#L695 ,
> "old_nd.mnt->mnt_root" is protected by spin_lock(&vfsmount_lock).
>
> Is spin_lock(&vfsmount_lock) unnecessary for referring "vfsmnt->mnt_root" ?
In other words, don't we need to protect vfsmnt->mnt_root at
http://lxr.linux.no/source/fs/dcache.c#L1383
using vfsmount_lock ?
Regards.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: vfsmount_lock in __d_path()
2006-05-31 11:14 ` vfsmount_lock in __d_path() Tetsuo Handa
@ 2006-05-31 12:20 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2006-05-31 12:20 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: linux-fsdevel
On Wed, May 31, 2006 at 08:14:22PM +0900, Tetsuo Handa wrote:
> Hello.
>
> I posted this message three months ago at kernelnewbies-ml, but no answer.
> Now reposting at fsdevel-ml.
->mnt_root is assigned once and that happens before vfsmount can be
found anywhere.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-31 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200603041038.BCC57442.GCOSMJNFtPXSFOFTFL@I-love.SAKURA.ne.jp>
2006-05-31 11:14 ` vfsmount_lock in __d_path() Tetsuo Handa
2006-05-31 12:20 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).