From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: [RFC][PATCH 19/27] sys_faccessat() elevate writer count Date: Wed, 07 Jun 2006 17:10:29 -0700 Message-ID: <20060608001029.80D57052@localhost.localdomain> References: <20060608001013.0D041507@localhost.localdomain> Cc: herbert@13thfloor.at, viro@ftp.linux.org.uk, hch@infradead.org, trond.myklebust@fys.uio.no, Dave Hansen Return-path: Received: from e5.ny.us.ibm.com ([32.97.182.145]:50906 "EHLO e5.ny.us.ibm.com") by vger.kernel.org with ESMTP id S932496AbWFHAKf (ORCPT ); Wed, 7 Jun 2006 20:10:35 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e5.ny.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k580AYSY013816 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Jun 2006 20:10:35 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.6/NCO/VER7.0) with ESMTP id k580AYmx263780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 7 Jun 2006 20:10:34 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k580AXpY005150 for ; Wed, 7 Jun 2006 20:10:34 -0400 To: linux-fsdevel@vger.kernel.org In-Reply-To: <20060608001013.0D041507@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Signed-off-by: Dave Hansen --- lxc-dave/fs/open.c | 16 ++++++++++++++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff -puN fs/open.c~elevate-writers-opens-part2-sys_faccessat2 fs/open.c --- lxc/fs/open.c~elevate-writers-opens-part2-sys_faccessat2 2006-06-07 16:53:23.000000000 -0700 +++ lxc-dave/fs/open.c 2006-06-07 16:53:23.000000000 -0700 @@ -542,9 +542,21 @@ asmlinkage long sys_faccessat(int dfd, c res = vfs_permission(&nd, mode); /* SuS v2 requires we report a read only fs too */ - if(!res && (mode & S_IWOTH) && IS_RDONLY(nd.dentry->d_inode) - && !special_file(nd.dentry->d_inode->i_mode)) + if(res) + goto out_path_release; + if (!(mode & S_IWOTH)) + goto out_path_release; + if (special_file(nd.dentry->d_inode->i_mode)) + goto out_path_release; + + res = mnt_want_write(nd.mnt); + if (res) { + mnt_drop_write(nd.mnt); + goto out_path_release; + } + if (IS_RDONLY(nd.dentry->d_inode)) res = -EROFS; +out_path_release: path_release(&nd); out: _