From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: [RFC][PATCH 21/27] mount_is_safe(): add comment Date: Wed, 07 Jun 2006 17:10:31 -0700 Message-ID: <20060608001031.DFF4082C@localhost.localdomain> References: <20060608001013.0D041507@localhost.localdomain> Cc: herbert@13thfloor.at, viro@ftp.linux.org.uk, hch@infradead.org, trond.myklebust@fys.uio.no, Dave Hansen Return-path: Received: from e5.ny.us.ibm.com ([32.97.182.145]:30683 "EHLO e5.ny.us.ibm.com") by vger.kernel.org with ESMTP id S932502AbWFHAKo (ORCPT ); Wed, 7 Jun 2006 20:10:44 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e5.ny.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k580Ah8w014012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Jun 2006 20:10:44 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.6/NCO/VER7.0) with ESMTP id k580Ads9183810 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 7 Jun 2006 20:10:39 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k580AcC5005286 for ; Wed, 7 Jun 2006 20:10:39 -0400 To: linux-fsdevel@vger.kernel.org In-Reply-To: <20060608001013.0D041507@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org This area of code is currently #ifdef'd out, so add a comment for the time when it is actually used. Signed-off-by: Dave Hansen --- lxc-dave/fs/namespace.c | 4 ++++ 1 files changed, 4 insertions(+) diff -puN fs/namespace.c~elevate-writers-opens-part5 fs/namespace.c --- lxc/fs/namespace.c~elevate-writers-opens-part5 2006-06-07 16:53:24.000000000 -0700 +++ lxc-dave/fs/namespace.c 2006-06-07 16:53:24.000000000 -0700 @@ -679,6 +679,10 @@ static int mount_is_safe(struct nameidat if (current->uid != nd->dentry->d_inode->i_uid) return -EPERM; } + /* + * We will eventually check for the mnt->writer_count here, + * but since the code is not used now, skipt it - Dave Hansen + */ if (vfs_permission(nd, MAY_WRITE)) return -EPERM; return 0; _