From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Poetzl Subject: Re: [RFC][PATCH 03/27] do_rmdir(): elevate write count Date: Thu, 8 Jun 2006 12:42:48 +0200 Message-ID: <20060608104248.GC11996@MAIL.13thfloor.at> References: <20060608001013.0D041507@localhost.localdomain> <20060608001016.24B1A11B@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, hch@infradead.org, trond.myklebust@fys.uio.no Return-path: Received: from MAIL.13thfloor.at ([212.16.62.50]:21640 "EHLO mail.13thfloor.at") by vger.kernel.org with ESMTP id S964779AbWFHKmt (ORCPT ); Thu, 8 Jun 2006 06:42:49 -0400 To: Dave Hansen Content-Disposition: inline In-Reply-To: <20060608001016.24B1A11B@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Jun 07, 2006 at 05:10:16PM -0700, Dave Hansen wrote: > > Elevate the write count during the vfs_rmdir() call. There > will be a lot of patches similar to this one coming up. > > Signed-off-by: Dave Hansen > --- > > lxc-dave/fs/namei.c | 5 +++++ > 1 files changed, 5 insertions(+) > > diff -puN fs/namei.c~rmdir1 fs/namei.c > --- lxc/fs/namei.c~rmdir1 2006-06-07 16:53:13.000000000 -0700 > +++ lxc-dave/fs/namei.c 2006-06-07 16:53:13.000000000 -0700 > @@ -2012,7 +2012,12 @@ static long do_rmdir(int dfd, const char > error = PTR_ERR(dentry); > if (IS_ERR(dentry)) > goto exit2; > + error = mnt_want_write(nd.mnt); > + if (error) > + goto exit3; > error = vfs_rmdir(nd.dentry->d_inode, dentry); > + mnt_drop_write(nd.mnt); > +exit3: IMHO, for consistency this should be named similar in all the different places, so maybe make that? out_put: or maybe: out_rdonly: (same goest for the following patches) otherwise fine best, Herbert > dput(dentry); > exit2: > mutex_unlock(&nd.dentry->d_inode->i_mutex); > _