From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [RFC][PATCH 23/27] elevate write count over calls to vfs_rename()
Date: Mon, 12 Jun 2006 19:18:04 +0100
Message-ID: <20060612181804.GE27946@ftp.linux.org.uk>
References: <20060608001013.0D041507@localhost.localdomain> <20060608001036.3B8AEAE2@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, herbert@13thfloor.at,
	hch@infradead.org, trond.myklebust@fys.uio.no
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:45792 "EHLO
	ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1751534AbWFLSSG
	(ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 12 Jun 2006 14:18:06 -0400
To: Dave Hansen <haveblue@us.ibm.com>
Content-Disposition: inline
In-Reply-To: <20060608001036.3B8AEAE2@localhost.localdomain>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Jun 07, 2006 at 05:10:36PM -0700, Dave Hansen wrote:
> +	error = mnt_want_write(oldnd.mnt);
>  	if (error)
>  		goto exit1;
>  
> +	error = do_path_lookup(newdfd, newname, LOOKUP_PARENT, &newnd);
> +	if (error)
> +		goto exit2;
> +
> +	error = mnt_want_write(oldnd.mnt);

WTF?  Why raise it twice?