From: Jan Blunck <jblunck@suse.de>
To: Neil Brown <neilb@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@osdl.org, viro@zeniv.linux.org.uk, dgc@sgi.com,
balbir@in.ibm.com
Subject: Re: [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version)
Date: Fri, 16 Jun 2006 17:51:20 +0200 [thread overview]
Message-ID: <20060616155120.GA6824@hasse.suse.de> (raw)
In-Reply-To: <17539.35118.103025.716435@cse.unsw.edu.au>
On Mon, Jun 05, Neil Brown wrote:
> I understand that this is where problem is because the selected
> dentries don't stay at the end of the list very long in some
> circumstances. In particular, other filesystems' dentries get mixed
> in.
No. The problem is that the LRU list is too long and therefore unmounting
seems to take ages.
> You have addressed this by having multiple unused lists so the
> dentries of other filesystems don't get mixed in.
>
> It seems to me that an alternate approach would be:
>
> - get select_parent and shrink_dcache_anon to move the selected
> dentries on to some new list.
> - pass this list to prune_dcache
> - splice any remainder back on to the global list when finished.
I had this idea too. At least select_parent could use something like that. But
that wouldn't help in the umount situation.
Jan
next prev parent reply other threads:[~2006-06-16 15:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 9:51 [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version) jblunck
2006-06-01 9:51 ` [patch 1/5] vfs: remove whitespace noise from fs/dcache.c jblunck
2006-06-01 9:51 ` [patch 2/5] vfs: d_genocide() doesnt add dentries to unused list jblunck
2006-06-01 9:51 ` [patch 3/5] vfs: remove shrink_dcache_anon() jblunck
2006-06-01 9:51 ` [patch 4/5] vfs: per superblock dentry stats jblunck
2006-06-01 9:51 ` [patch 5/5] vfs: per superblock dentry unused list jblunck
2006-06-02 1:06 ` [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version) Andrew Morton
2006-06-02 2:23 ` David Chinner
2006-06-02 2:49 ` Andrew Morton
2006-06-02 4:17 ` David Chinner
2006-06-02 15:33 ` Jan Blunck
2006-06-05 1:30 ` Neil Brown
2006-06-16 15:51 ` Jan Blunck [this message]
2006-06-16 22:25 ` Neil Brown
2006-06-18 23:56 ` David Chinner
2006-06-19 0:27 ` Neil Brown
2006-06-19 1:00 ` David Chinner
2006-06-19 1:21 ` Neil Brown
2006-06-19 2:04 ` Andrew Morton
2006-06-19 2:25 ` Neil Brown
2006-06-19 5:55 ` David Chinner
2006-06-19 6:33 ` Andrew Morton
2006-06-19 8:30 ` David Chinner
2006-06-19 10:48 ` Thomas Gleixner
2006-06-19 11:01 ` Andrew Morton
2006-06-19 17:34 ` Ravinandan Arakali
2006-06-20 0:37 ` Andrew Morton
2006-06-20 21:34 ` Ravinandan Arakali
2006-06-20 22:10 ` Andrew Morton
2006-06-20 23:56 ` Ravinandan Arakali
2006-06-21 0:18 ` Andrew Morton
2006-06-21 0:31 ` Ravinandan Arakali
2006-06-19 9:34 ` Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060616155120.GA6824@hasse.suse.de \
--to=jblunck@suse.de \
--cc=akpm@osdl.org \
--cc=balbir@in.ibm.com \
--cc=dgc@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).