From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Poetzl Subject: Re: [RFC][PATCH 00/20] Mount writer count and read-only bind mounts (v2) Date: Sat, 17 Jun 2006 15:29:21 +0200 Message-ID: <20060617132921.GA21326@MAIL.13thfloor.at> References: <20060616231213.D4C5D6AF@localhost.localdomain> <1150501318.7926.22.camel@localhost.localdomain> <20060617033531.GA25823@MAIL.13thfloor.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Grzegorz Kulewski , Dave Hansen , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk Return-path: Received: from MAIL.13thfloor.at ([212.16.62.50]:29588 "EHLO mail.13thfloor.at") by vger.kernel.org with ESMTP id S1751577AbWFQN3W (ORCPT ); Sat, 17 Jun 2006 09:29:22 -0400 To: Jan Engelhardt Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Jun 17, 2006 at 11:36:35AM +0200, Jan Engelhardt wrote: > >> >I assume you're talking about this kind of situation: > >> > > >> >mount --bind /local/writable/dir /chroot/untrusted/area/ > >> >mount --o remount,ro /chroot/untrusted/area/ > >> > >> Well, actually about some kind of VPS: openvz or something like that. > >> But yes, this is the same kind of scenario. > > > >yes, Linux-VServer provides this kind of ro --bind mounts > >without the race, as the the flags are passed on the actual > >mount > > > >> >This has no r/w window in the chroot area: > >> > > >> >mount --bind /local/writable/dir /tmp/area/ > >> >mount --o remount,ro /tmp/area/ > >> >mount --bind /tmp/area/ /chroot/untrusted/area/ > >> >umount /tmp/area/ > >> > >> Well, it looks a little scarry and complicated at first. And probably > >> requires you to know that semantic of --bind lets you do the last > >> unmount. But if you are saying that this makes kernel smaller, faster > >> and less buggy then you are probably very right. > > > >well, it makes the kernel more consistant in it's behaviour, > >because especially for --rbind mounts, the logic what is > >changed where and when is not as well defined as one would > >wish ... > > > >btw, you could get the same result by simply doing: > > > >mount --bind /local/writable/dir /tmp/area/ > >mount --o remount,ro /tmp/area/ > >mount --move /tmp/area/ /chroot/untrusted/area/ > > > > Just a nitpick, you all use "--o" ... :) > mount: option `--o' is ambiguous sorry, copy paste error on my side :) (probably for Dave too ...) best, Herbert > Jan Engelhardt > --