From: Andrew Morton <akpm@osdl.org>
To: Neil Brown <neilb@suse.de>
Cc: dgc@sgi.com, jblunck@suse.de, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
balbir@in.ibm.com
Subject: Re: [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version)
Date: Sun, 18 Jun 2006 19:04:22 -0700 [thread overview]
Message-ID: <20060618190422.5daf17fe.akpm@osdl.org> (raw)
In-Reply-To: <17557.64512.496195.714144@cse.unsw.edu.au>
On Mon, 19 Jun 2006 11:21:04 +1000
Neil Brown <neilb@suse.de> wrote:
> static void prune_dcache(int count, struct super_block *sb)
> +static void prune_dcache(int count, struct list_head *list)
> {
> + int have_list = list != NULL;
> + struct list_head alt_head;
> spin_lock(&dcache_lock);
> + if (list == NULL) {
> + /* use the dentry_unused list */
> + list_add(&alt_head, &dentry_unused);
> + list_del_init(&dentry_unused);
> + list = &alt_head;
> + }
This will make dentry_unused appear to be empty.
> for (; count ; count--) {
> struct dentry *dentry;
> struct list_head *tmp;
> @@ -405,23 +417,11 @@ static void prune_dcache(int count, stru
>
> cond_resched_lock(&dcache_lock);
And then it makes that apparent-emptiness globally visible.
Won't this cause concurrent unmounting or memory shrinking to malfunction?
next prev parent reply other threads:[~2006-06-19 2:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 9:51 [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version) jblunck
2006-06-01 9:51 ` [patch 1/5] vfs: remove whitespace noise from fs/dcache.c jblunck
2006-06-01 9:51 ` [patch 2/5] vfs: d_genocide() doesnt add dentries to unused list jblunck
2006-06-01 9:51 ` [patch 3/5] vfs: remove shrink_dcache_anon() jblunck
2006-06-01 9:51 ` [patch 4/5] vfs: per superblock dentry stats jblunck
2006-06-01 9:51 ` [patch 5/5] vfs: per superblock dentry unused list jblunck
2006-06-02 1:06 ` [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version) Andrew Morton
2006-06-02 2:23 ` David Chinner
2006-06-02 2:49 ` Andrew Morton
2006-06-02 4:17 ` David Chinner
2006-06-02 15:33 ` Jan Blunck
2006-06-05 1:30 ` Neil Brown
2006-06-16 15:51 ` Jan Blunck
2006-06-16 22:25 ` Neil Brown
2006-06-18 23:56 ` David Chinner
2006-06-19 0:27 ` Neil Brown
2006-06-19 1:00 ` David Chinner
2006-06-19 1:21 ` Neil Brown
2006-06-19 2:04 ` Andrew Morton [this message]
2006-06-19 2:25 ` Neil Brown
2006-06-19 5:55 ` David Chinner
2006-06-19 6:33 ` Andrew Morton
2006-06-19 8:30 ` David Chinner
2006-06-19 10:48 ` Thomas Gleixner
2006-06-19 11:01 ` Andrew Morton
2006-06-19 17:34 ` Ravinandan Arakali
2006-06-20 0:37 ` Andrew Morton
2006-06-20 21:34 ` Ravinandan Arakali
2006-06-20 22:10 ` Andrew Morton
2006-06-20 23:56 ` Ravinandan Arakali
2006-06-21 0:18 ` Andrew Morton
2006-06-21 0:31 ` Ravinandan Arakali
2006-06-19 9:34 ` Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060618190422.5daf17fe.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=balbir@in.ibm.com \
--cc=dgc@sgi.com \
--cc=jblunck@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).