From: Al Viro <viro@ftp.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/5]: ufs: missed brelse and wrong baseblk
Date: Mon, 19 Jun 2006 20:13:06 +0100 [thread overview]
Message-ID: <20060619191306.GK27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20060619185816.GA26513@rain.homenetwork>
On Mon, Jun 19, 2006 at 10:58:16PM +0400, Evgeniy Dushistov wrote:
> On Mon, Jun 19, 2006 at 07:28:33PM +0100, Al Viro wrote:
> > On Mon, Jun 19, 2006 at 05:17:50PM +0400, Evgeniy Dushistov wrote:
> > > In case of 1k fragments, msync of two pages
> > > cause 8 calls of ufs's get_block_t with create == 1,
> > > they will be consequent because of synchronization.
> >
> > _What_ synchronization?
> > Now, which lock would, in your opinion, provide serialization between these
> > two calls? They apply to different pages, so page locks do not help.
> >
> you can look at fs/ufs/inode.c: ufs_getfrag_block.
> It is ufs's get_block_t,
> if create == 1 it uses "[un]lock_kernel".
Which is fsck-all protection, since then you proceed to do a lot of
blocking operations. Now, lock_super() down in balloc.c _might_ be
enough, but I wouldn't bet on that.
next prev parent reply other threads:[~2006-06-19 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-17 10:14 [PATCH 1/5]: ufs: missed brelse and wrong baseblk Evgeniy Dushistov
2006-06-18 16:20 ` Al Viro
2006-06-18 17:50 ` Al Viro
2006-06-19 6:47 ` Evgeniy Dushistov
2006-06-19 7:32 ` Al Viro
2006-06-19 13:17 ` Evgeniy Dushistov
2006-06-19 18:28 ` Al Viro
2006-06-19 18:58 ` Evgeniy Dushistov
2006-06-19 19:13 ` Al Viro [this message]
2006-06-20 16:30 ` Evgeniy Dushistov
2006-06-20 16:30 ` Evgeniy Dushistov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060619191306.GK27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).