From: Andrew Morton <akpm@osdl.org>
To: <ravinandan.arakali@neterion.com>
Cc: tglx@linutronix.de, dgc@sgi.com, mingo@elte.hu, neilb@suse.de,
jblunck@suse.de, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
balbir@in.ibm.com, ananda.raju@neterion.com,
leonid.grossman@neterion.com, jes@trained-monkey.org
Subject: Re: [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version)
Date: Tue, 20 Jun 2006 17:18:31 -0700 [thread overview]
Message-ID: <20060620171831.32c9009a.akpm@osdl.org> (raw)
In-Reply-To: <007601c694c5$359c4620$3e10100a@pc.s2io.com>
"Ravinandan Arakali" <ravinandan.arakali@neterion.com> wrote:
>
> The formal submission will take some more time.
> To boot your system, can you use the driver available on our website ?
Not really - it's not my system and I'd need to monkey around and generate
a diff which I then cannot test.
The driver you have there (REL_2.0.14.5152_LX.tar.gz) doesn't actually
appear to fix the bug:
int s2io_open(struct net_device *dev)
{
nic_t *sp = dev->priv;
int err = 0;
/*
* Make sure you have link off by default every time
* Nic is initialized
*/
netif_carrier_off(dev);
sp->last_link_state = 0;
/* Initialize H/W and enable interrupts */
err = s2io_card_up(sp);
if (err) {
DBG_PRINT(ERR_DBG, "%s: H/W initialization failed\n",
dev->name);
if (err == -ENODEV)
goto hw_init_failed;
else
goto hw_enable_failed;
}
#ifdef CONFIG_PCI_MSI
/* Store the values of the MSIX table in the nic_t structure */
store_xmsi_data(sp);
/* After proper initialization of H/W, register ISR */
if (sp->intr_type == MSI) {
err = request_irq((int) sp->pdev->irq, s2io_msi_handle,
SA_SHIRQ, sp->name, dev);
It's still calling request_irq() _after_ "enable interrupts".
next prev parent reply other threads:[~2006-06-21 0:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 9:51 [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version) jblunck
2006-06-01 9:51 ` [patch 1/5] vfs: remove whitespace noise from fs/dcache.c jblunck
2006-06-01 9:51 ` [patch 2/5] vfs: d_genocide() doesnt add dentries to unused list jblunck
2006-06-01 9:51 ` [patch 3/5] vfs: remove shrink_dcache_anon() jblunck
2006-06-01 9:51 ` [patch 4/5] vfs: per superblock dentry stats jblunck
2006-06-01 9:51 ` [patch 5/5] vfs: per superblock dentry unused list jblunck
2006-06-02 1:06 ` [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version) Andrew Morton
2006-06-02 2:23 ` David Chinner
2006-06-02 2:49 ` Andrew Morton
2006-06-02 4:17 ` David Chinner
2006-06-02 15:33 ` Jan Blunck
2006-06-05 1:30 ` Neil Brown
2006-06-16 15:51 ` Jan Blunck
2006-06-16 22:25 ` Neil Brown
2006-06-18 23:56 ` David Chinner
2006-06-19 0:27 ` Neil Brown
2006-06-19 1:00 ` David Chinner
2006-06-19 1:21 ` Neil Brown
2006-06-19 2:04 ` Andrew Morton
2006-06-19 2:25 ` Neil Brown
2006-06-19 5:55 ` David Chinner
2006-06-19 6:33 ` Andrew Morton
2006-06-19 8:30 ` David Chinner
2006-06-19 10:48 ` Thomas Gleixner
2006-06-19 11:01 ` Andrew Morton
2006-06-19 17:34 ` Ravinandan Arakali
2006-06-20 0:37 ` Andrew Morton
2006-06-20 21:34 ` Ravinandan Arakali
2006-06-20 22:10 ` Andrew Morton
2006-06-20 23:56 ` Ravinandan Arakali
2006-06-21 0:18 ` Andrew Morton [this message]
2006-06-21 0:31 ` Ravinandan Arakali
2006-06-19 9:34 ` Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060620171831.32c9009a.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ananda.raju@neterion.com \
--cc=balbir@in.ibm.com \
--cc=dgc@sgi.com \
--cc=jblunck@suse.de \
--cc=jes@trained-monkey.org \
--cc=leonid.grossman@neterion.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=neilb@suse.de \
--cc=ravinandan.arakali@neterion.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).