From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Halcrow Subject: Re: [PATCH 2/12] Support for larger maximum key size Date: Wed, 21 Jun 2006 10:50:14 -0500 Message-ID: <20060621155014.GB2682@us.ibm.com> References: <1150901397.24002.11.camel@localhost.localdomain> Reply-To: Michael Halcrow Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="A6N2fC+uXW/VQSAv" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mike Halcrow Return-path: Received: from e34.co.us.ibm.com ([32.97.110.152]:34205 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S1751053AbWFUPuX (ORCPT ); Wed, 21 Jun 2006 11:50:23 -0400 To: "Timothy R. Chavez" Content-Disposition: inline In-Reply-To: <1150901397.24002.11.camel@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --A6N2fC+uXW/VQSAv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 21, 2006 at 09:49:57AM -0500, Timothy R. Chavez wrote: > > - ECRYPTFS_MAX_ENCRYPTED_KEY_BYTES; > > - for (i =3D 0; i < auth_tok->session_key.encrypted_key_size; i++) > > + for (i =3D 0; i < (crypt_stat->key_size_bits / 8); i++) >=20 > Why don't you just do this particular calculation once? Just looking > down, you do this same calculation at least 4 other potential times. Patch #10 in this set changes the keysize to bytes, so this is a resolved issue. Thanks, Mike --A6N2fC+uXW/VQSAv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iQEVAwUBRJlqtdtAhTFtyodpAQI6fgf9FtwZQXB/yZGDf/B1pC//rxbsV7d3+PI3 /q4mkXlUrL79v4yyd+e00hSReBbK/oGz3qQgxXnTIEFrcx44tI/ahR/BgWMXl3sb 293och5Qe5TvO0UA+6rVET4gzui56XK3UAPigPl+6azWoqLmKvUG2x8aRYpuN4am 29yDE/ffme8XWCHlPDFMssnvbZjZIddqhs4S62M2Z53fhLUyheOyTUxcPQSXtBcq 7fS98cTrzs8d8sbG/pkvVFi8OMcjx37pj7jm145gV9DsaKLbBUKIaWxggxsYdR8j Q+flyCRNZgHunFwis4wLNQwcKQsd7DhiiKTM7Ruvu0cvn4przC57Vg== =OnOq -----END PGP SIGNATURE----- --A6N2fC+uXW/VQSAv--