From: Chris Mason <mason@suse.com>
To: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: reiserfs-list@namesys.com, reiser@namesys.com,
reiserfs-dev@namesys.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] reiserfs:fix journaling issue regarding fsync()
Date: Fri, 30 Jun 2006 08:24:10 -0400 [thread overview]
Message-ID: <200606300824.12352.mason@suse.com> (raw)
In-Reply-To: <6.0.0.20.2.20060630094908.0411c9d0@172.19.0.2>
On Thursday 29 June 2006 21:36, Hisashi Hifumi wrote:
> Hi,
>
> At 09:47 06/06/30, Chris Mason wrote:
> >Thanks for the patch. One problem is this will bump the transaction
> > marker for atime updates too. I'd rather see the change done inside
> >reiserfs_file_write.
>
> I did not realize that an atime updates is also influenced.
>
> >reiserfs_file_write already updates the transaction when blocks are
> > allocated, but you're right that to be 100% correct we should cover the
> > case when i_size increases but new blocks are not added. Was this the
> > case you were trying to fix?
>
> Yes, that's right.
>
> So, I remade my patch as follows.
> I tested this patch and confirmed that the kernel with this patch work
> well.
This is correct, excpet you need to put the update_inode_transaction call
inside reiserfs_write_lock/unlock.
-chris
next prev parent reply other threads:[~2006-06-30 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 8:43 [PATCH] reiserfs:fix journaling issue regarding fsync() Hisashi Hifumi
2006-06-23 10:15 ` Vladimir V. Saveliev
2006-06-23 15:53 ` Hans Reiser
2006-06-26 4:39 ` Hisashi Hifumi
2006-06-30 0:47 ` Chris Mason
2006-06-30 1:36 ` Hisashi Hifumi
2006-06-30 12:24 ` Chris Mason [this message]
2006-06-30 22:59 ` Hisashi Hifumi
2006-07-01 19:34 ` Chris Mason
2006-07-02 15:34 ` Hans Reiser
2006-07-03 1:31 ` Hisashi Hifumi
2006-07-03 1:36 ` Andrew Morton
2006-07-03 2:03 ` Hisashi Hifumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606300824.12352.mason@suse.com \
--to=mason@suse.com \
--cc=hifumi.hisashi@oss.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=reiser@namesys.com \
--cc=reiserfs-dev@namesys.com \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).