From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [LOCKDEP] xfs: possible recursive locking detected Date: Tue, 4 Jul 2006 15:03:38 +0200 Message-ID: <20060704130338.GA4354@elte.hu> References: <20060704004116.GA7612@martell.zuzino.mipt.ru> <20060704011858.GG1605@parisc-linux.org> <20060704112503.H1495869@wobbly.melbourne.sgi.com> <20060704063225.GA2752@elte.hu> <20060704084143.GA12931@elte.hu> <20060704191100.C1497438@wobbly.melbourne.sgi.com> <20060704095743.GA21480@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexey Dobriyan , Matthew Wilcox , linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, Arjan van de Ven Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:48350 "EHLO mx3.mail.elte.hu") by vger.kernel.org with ESMTP id S932149AbWGDNIV (ORCPT ); Tue, 4 Jul 2006 09:08:21 -0400 To: Nathan Scott Content-Disposition: inline In-Reply-To: <20060704095743.GA21480@elte.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org another thing: i have added real 'lock allocation debugging' (CONFIG_DEBUG_LOCK_ALLOC) to the kernel, which covers spinlocks, rwlocks, mutexes and rw-semaphores. It does the following: This feature will check whether any held lock (spinlock, rwlock, mutex or rwsem) is incorrectly freed by the kernel, via any of the memory-freeing routines (kfree(), kmem_cache_free(), free_pages(), vfree(), etc.), whether a live lock is incorrectly reinitialized via spin_lock_init()/mutex_init()/etc., or whether there is any lock held during task exit. so i suspect: fs/xfs/xfs_mount.h:#define AIL_LOCK_DESTROY(x) spinlock_destroy(x) fs/xfs/linux-2.6/spin.h:#define spinlock_destroy(lock) needs to change and we need to implement spinlock_destroy(), a'ka mutex_destroy()? [which i added recently too] Ingo