Re: [PATCH 14/21] FS-Cache: Avoid ENFILE checking for kernel-specific open files

[Christoph Hellwig <hch@infradead.org>]

On Thu, Jul 06, 2006 at 11:10:53AM -0400, Trond Myklebust wrote:
> From: David Howells <dhowells@redhat.com>
> 
> Make it possible to avoid ENFILE checking for kernel specific open files, such
> as are used by the CacheFiles module.
> 
> After, for example, tarring up a kernel source tree over the network, the
> CacheFiles module may easily have 20000+ files open in the backing filesystem,
> thus causing all non-root processes to be given error ENFILE when they try to
> open a file, socket, pipe, etc..

Big fat NACK/.  If you don't want file accouting don't use files.  The
actual users of this unfortunately wasn't posted, but it's using files
only as the optional arguments to ->readpage, to call ->flush and for
->setattr.  You could do all that aswell at the fs level.  Besides that
unposted patch adds various odd exports, another silly write something
variant in filemap.c, etc..  Also the documentation claims it needs FIBMAP
support from userspace which is a big no-way.  Can we please get a clear
description why all this bloat is needed?

Also David, please try to follow the kernel codingstyle.  No silly

	} /* end silly function */

comments.  No

/*****************************************************************************/

lines before b lock comments, please follow kernel doc style instead.

Also please don't add _MODULE ifdefs in headers.