From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: [PATCH 3/3] VFS: Remove redundant open-coded mode bit checks in open_exec(). Date: Wed, 12 Jul 2006 13:50:12 -0400 Message-ID: <20060712175012.7413.24685.stgit@lade.trondhjem.org> References: <20060712175006.7413.91738.stgit@lade.trondhjem.org> Content-Type: text/plain; charset=utf-8; format=fixed Content-Transfer-Encoding: 8bit Return-path: Received: from dh134.citi.umich.edu ([141.211.133.134]:39362 "EHLO lade.trondhjem.org") by vger.kernel.org with ESMTP id S932188AbWGLRuN (ORCPT ); Wed, 12 Jul 2006 13:50:13 -0400 To: linux-fsdevel@vger.kernel.org, akpm@osdl.org In-Reply-To: <20060712175006.7413.91738.stgit@lade.trondhjem.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org From: Trond Myklebust The check in open_exec() for inode->i_mode & 0111 has been made redundant by the fix to permission(). Signed-off-by: Trond Myklebust --- fs/exec.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fs/exec.c b/fs/exec.c index a6f64a9..f7aabfe 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -486,8 +486,6 @@ struct file *open_exec(const char *name) if (!(nd.mnt->mnt_flags & MNT_NOEXEC) && S_ISREG(inode->i_mode)) { int err = vfs_permission(&nd, MAY_EXEC); - if (!err && !(inode->i_mode & 0111)) - err = -EACCES; file = ERR_PTR(err); if (!err) { file = nameidata_to_filp(&nd, O_RDONLY);