Re: [PATCH] Fix reiserfs latencies caused by data=ordered

[Chris Mason <mason@suse.com>]

On Fri, Aug 04, 2006 at 04:01:22PM -0700, Andrew Morton wrote:
> On Fri, 4 Aug 2006 10:07:08 -0400
> Chris Mason <mason@suse.com> wrote:
> 
> > ReiserFS does periodic cleanup of old transactions in order to limit the
> > length of time a journal replay may take after a crash.  Sometimes, writing
> > metadata from an old (already committed) transaction may require committing
> > a newer transaction, which also requires writing all data=ordered buffers.
> > This can cause very long stalls on journal_begin.
> > 
> > This patch makes sure new transactions will not need to be committed before
> > trying a periodic reclaim of an old transaction.  It is low risk because
> > if a bad decision is made, it just means a slightly longer journal
> > replay after a crash.
> 
> So I'm thinking that these:
> 
> i_mutex-does-not-need-to-be-locked-in-reiserfs_delete_inode.patch
> fix-reiserfs-lock-inversion-of-bkl-vs-inode-semaphore.patch (akpm modified)
> reiserfs_write_full_page-should-not-get_block-past-eof.patch
> 
> are 2.6.18 material.  What are your thoughts on that?

Ack from me.

-chris