From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthew Wilcox <matthew@wil.cx>
Subject: Re: [patch] add flags to stat()
Date: Mon, 7 Aug 2006 08:23:02 -0600
Message-ID: <20060807142302.GM4379@parisc-linux.org>
References: <Pine.LNX.4.64.0608061158060.1620@sg1>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from palinux.external.hp.com ([192.25.206.14]:42673 "EHLO
	palinux.external.hp.com") by vger.kernel.org with ESMTP
	id S1750729AbWHGOXD (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 7 Aug 2006 10:23:03 -0400
To: Ameer Armaly <ameer@bellsouth.net>
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0608061158060.1620@sg1>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Sun, Aug 06, 2006 at 11:58:26AM -0400, Ameer Armaly wrote:
> -asmlinkage long sys_newstat(char __user *filename, struct stat __user 
> *statbuf)
> +asmlinkage long sys_newstat(char __user *filename, struct stat __user 
> *statbuf, unsigned int flags)
>   {
>   	struct kstat stat;
> -	int error = vfs_stat_fd(AT_FDCWD, filename, &stat);
> +	int error;
> +        if(!flags) /*The want everything, so let's flip on all the flags.*/
> +                --flags;
> +	error = vfs_stat_fd(AT_FDCWD, filename, &stat, flags);

You can't assume that old programs calling sys_newstat will happen to
have a 0 in the flags argument.  Look at how we handled this for
sys_mount (MS_MGC_VAL).

Or introduce new syscalls with flags, of course.