From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/5] Forking ext4 filesystem from ext3 filesystem Date: Wed, 9 Aug 2006 23:39:14 -0700 Message-ID: <20060809233914.35ab8792.akpm@osdl.org> References: <1155172622.3161.73.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Return-path: To: cmm@us.ibm.com In-Reply-To: <1155172622.3161.73.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ext2-devel-bounces@lists.sourceforge.net Errors-To: ext2-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org On Wed, 09 Aug 2006 18:17:02 -0700 Mingming Cao wrote: > Fork(copy) ext4 filesystem from ext3 filesystem. Rename all functions in ext4 from ext3_xxx() to ext4_xxx(). It would have been nice to spend a few hours cleaning up ext3 and JBD before doing this. The code isn't toooo bad, but there are number of coding style problems, whitespace screwups, incorrect comments, missing comments, poorly-chosen variable names and all of that sort of thing. One the fs has been copied-and-pasted, it's much harder to address these things: either need to do it twice, or allow the filesystems to diverge, or not do it. Also, -mm presently has two patches pending against fs/jbd/ and nine pending against fs/ext3/. We should get all those things merged before taking the copy. Also, JBD is presently feeding into submit_bh() buffer_heads which span two machine pages, and some device drivers spit the dummy. It'd be better to fix that once, rather than twice.. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642