From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 4/9] 48bit support in extents Date: Wed, 9 Aug 2006 23:40:54 -0700 Message-ID: <20060809234054.f9365c4b.akpm@osdl.org> References: <1155172873.3161.83.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Return-path: To: cmm@us.ibm.com In-Reply-To: <1155172873.3161.83.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ext2-devel-bounces@lists.sourceforge.net Errors-To: ext2-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org On Wed, 09 Aug 2006 18:21:13 -0700 Mingming Cao wrote: > +/* this macro combines low and hi parts of phys. blocknr into ext4_fsblk_t */ This isn't a macro. > +static inline ext4_fsblk_t ext_pblock(struct ext4_extent *ex) > +{ > + ext4_fsblk_t block; > + > + block = le32_to_cpu(ex->ee_start); > + if (sizeof(ext4_fsblk_t) > 4) > + block |= ((ext4_fsblk_t) le16_to_cpu(ex->ee_start_hi) << 31) << 1; > + return block; > +} Oh. I see the other patch did typedef sector_t ext4_fs_block_t; (except someone misspelled "block" as "blk" ;)) Do we really want to do this? I guess there's some value, for people with 32-bit machines who want extents and who are too mean to use a 64-bit sector_t. But gee that's marginal. And it introduces interesting compatibility questions and significantly adds to the testing burden. I think that requiring 64-bit sector_t is reasonable? Then again, I see from the other patches that considerable thought and effort has gone into sustaining this turkey, so I guess I'm missing something again. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642