From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/9] extents for ext4 Date: Thu, 10 Aug 2006 02:48:16 -0700 Message-ID: <20060810024816.9d83c944.akpm@osdl.org> References: <1155172827.3161.80.camel@localhost.localdomain> <20060809233940.50162afb.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net, cmm@us.ibm.com, linux-kernel@vger.kernel.org Return-path: To: Alex Tomas In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ext2-devel-bounces@lists.sourceforge.net Errors-To: ext2-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org On Thu, 10 Aug 2006 13:29:56 +0400 Alex Tomas wrote: > AM> - The code is very poorly commented. I'd want to spend a lot of time > AM> reviewing this implementation, but not in its present state. > > what sort of comments are you expecting? Ones which tell me what the code is attempting to do. Ones which tell me the things which I need to know and which I cannot determine from the implementation within a reasonable period of time. Ones which tell me about the hidden design decisions, the known shortcomings, the things-still-to-do. It's a bit of an artform, really. I guess one needs to put oneself in the position of the reader, then work out what the reader wants to know. Good examples don't immediately leap to mind, I'm afraid. Maybe some of fs/buffer.c? That's important and pretty tricky code in there, so it goes to some lengths. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642