From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Alex Tomas <alex@clusterfs.com>
Cc: Andrew Morton <akpm@osdl.org>,
cmm@us.ibm.com, linux-fsdevel@vger.kernel.org,
ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Ext2-devel] [PATCH 1/9] extents for ext4
Date: Thu, 10 Aug 2006 10:49:54 -0700 [thread overview]
Message-ID: <20060810104954.0e03c83e.rdunlap@xenotime.net> (raw)
In-Reply-To: <m37j1hlyzv.fsf@bzzz.home.net>
On Thu, 10 Aug 2006 13:29:56 +0400 Alex Tomas wrote:
> >>>>> Andrew Morton (AM) writes:
>
> >> From a quick scan:
>
> AM> - The code is very poorly commented. I'd want to spend a lot of time
> AM> reviewing this implementation, but not in its present state.
>
> what sort of comments are you expecting?
Helpful ones. Not obvious stuff. Intents.
Tricks used (if they are the right thing to do).
How, what, why. But not nitty-gritty details of how.
"Why" is often more important.
> AM> - The existing comments could benefit from some rework by a native English
> AM> speaker.
>
> could someone assist here, please?
Yes. How would you like it? Just comments via email or (quilt) patches?
Which files/patches?
---
~Randy
next prev parent reply other threads:[~2006-08-10 17:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 1:20 [PATCH 1/9] extents for ext4 Mingming Cao
2006-08-10 6:39 ` Andrew Morton
2006-08-10 9:29 ` Alex Tomas
2006-08-10 9:48 ` Andrew Morton
2006-08-10 10:08 ` Alex Tomas
2006-08-10 15:55 ` Zach Brown
2006-08-10 17:49 ` Randy.Dunlap [this message]
2006-08-10 19:05 ` Alex Tomas
2006-08-11 20:57 ` Randy.Dunlap
2006-08-11 21:05 ` Alex Tomas
2006-08-11 21:49 ` [Ext2-devel] " Mingming Cao
2006-08-11 23:00 ` Andrew Morton
2006-08-12 6:02 ` [Ext2-devel] " Randy.Dunlap
2006-08-12 17:43 ` Darrick J. Wong
2006-08-12 18:20 ` Randy.Dunlap
2006-08-14 16:26 ` [Ext2-devel] " Mingming Cao
2006-08-14 17:22 ` Randy.Dunlap
2006-08-14 17:52 ` [Ext2-devel] " Jeff Garzik
2006-08-14 18:05 ` Randy.Dunlap
2006-08-14 18:13 ` Jeff Garzik
2006-08-15 15:40 ` [Ext2-devel] " Pavel Machek
2006-08-18 13:08 ` Andreas Dilger
2006-08-10 16:46 ` Mingming Cao
2006-08-10 17:17 ` Theodore Tso
2006-08-10 18:00 ` Andrew Morton
2006-08-11 22:13 ` Mingming Cao
2006-08-11 23:16 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2006-08-15 21:27 [Ext2-devel] " Randy Dunlap
2006-08-15 23:19 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810104954.0e03c83e.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=alex@clusterfs.com \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).