From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Randy.Dunlap" Subject: Re: [Ext2-devel] [PATCH 1/9] extents for ext4 Date: Thu, 10 Aug 2006 10:49:54 -0700 Message-ID: <20060810104954.0e03c83e.rdunlap@xenotime.net> References: <1155172827.3161.80.camel@localhost.localdomain> <20060809233940.50162afb.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Andrew Morton , cmm@us.ibm.com, linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Return-path: Received: from xenotime.net ([66.160.160.81]:35559 "HELO xenotime.net") by vger.kernel.org with SMTP id S1422661AbWHJRrM (ORCPT ); Thu, 10 Aug 2006 13:47:12 -0400 Received: from midway.site ([71.117.253.75]) by xenotime.net for ; Thu, 10 Aug 2006 10:47:08 -0700 To: Alex Tomas In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 10 Aug 2006 13:29:56 +0400 Alex Tomas wrote: > >>>>> Andrew Morton (AM) writes: > > >> From a quick scan: > > AM> - The code is very poorly commented. I'd want to spend a lot of time > AM> reviewing this implementation, but not in its present state. > > what sort of comments are you expecting? Helpful ones. Not obvious stuff. Intents. Tricks used (if they are the right thing to do). How, what, why. But not nitty-gritty details of how. "Why" is often more important. > AM> - The existing comments could benefit from some rework by a native English > AM> speaker. > > could someone assist here, please? Yes. How would you like it? Just comments via email or (quilt) patches? Which files/patches? --- ~Randy