From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/9] extents for ext4 Date: Thu, 10 Aug 2006 11:00:47 -0700 Message-ID: <20060810110047.af273a55.akpm@osdl.org> References: <1155172827.3161.80.camel@localhost.localdomain> <20060809233940.50162afb.akpm@osdl.org> <20060810171755.GA19238@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net, cmm@us.ibm.com, linux-kernel@vger.kernel.org Return-path: To: Theodore Tso In-Reply-To: <20060810171755.GA19238@thunk.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ext2-devel-bounces@lists.sourceforge.net Errors-To: ext2-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org On Thu, 10 Aug 2006 13:17:55 -0400 Theodore Tso wrote: > On Wed, Aug 09, 2006 at 11:39:40PM -0700, Andrew Morton wrote: > > - replace all brelse() calls with put_bh(). Because brelse() is > > old-fashioned, has a weird name and neelessly permits a NULL arg. > > > > In fact it would be beter to convert JBD and ext3 to put_bh before > > copying it all over. > > Wouldn't it be better to preserve in the source code history the > brelse->put_bh conversion? We can pour a huge number of changes in > ext4 before we submit, but I would have thought it would be easier for > everyone to see what is going on if we submit with just the minimal > changes, and then have patches that address concerns like this one at > a time. > I'd suggest that this be one of the cleanups which be done within ext3 before taking the ext4 copy. That's assuming we want to do the spring-cleaning - we might of course decide not to. But it'd be a good time to do so. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642