From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Mingming Cao <cmm@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/5] Forking ext4 filesystem from ext3 filesystem
Date: Thu, 10 Aug 2006 18:48:32 +0200 [thread overview]
Message-ID: <20060810164832.GA305@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <44DB61D7.1000109@us.ibm.com>
On Thu, 10 August 2006 09:41:59 -0700, Mingming Cao wrote:
>
> I agree with you that the timing is right, to do the clean up now rather
> than later. I would give it a try. If I could get more help from more
> code reviewer, it probably makes the effort a lot easier. For those
> issues you pointed out : coding style problem??incorrect comments,
> poorly-named variables -- do you have any specific examples in your mind?
For whitespace damage, you can try the following regex:
/\s\+$\| \+\ze\t/
Or if you use vim as an editor, you can add this to your vimrc:
highlight RedundantSpaces ctermbg=red guibg=red
match RedundantSpaces /\s\+$\| \+\ze\t/
For example, it will show 4 cases of trailing whitespace in the quoted
part of your email above. :)
Jörn
--
You ain't got no problem, Jules. I'm on the motherfucker. Go back in
there, chill them niggers out and wait for the Wolf, who should be
coming directly.
-- Marsellus Wallace
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2006-08-10 16:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 1:17 [PATCH 1/5] Forking ext4 filesystem from ext3 filesystem Mingming Cao
2006-08-10 6:39 ` Andrew Morton
2006-08-10 16:41 ` Mingming Cao
2006-08-10 16:48 ` Jörn Engel [this message]
2006-08-10 18:18 ` Andrew Morton
2006-08-10 20:22 ` Jeff Garzik
2006-08-10 20:33 ` Andrew Morton
2006-08-10 20:52 ` Jeff Garzik
2006-08-10 17:44 ` Theodore Tso
2006-08-10 18:51 ` Badari Pulavarty
2006-08-10 19:23 ` Andrew Morton
2006-08-10 19:36 ` Dave Kleikamp
2006-08-10 19:54 ` Andrew Morton
2006-08-10 20:12 ` Jeff Garzik
2006-08-10 20:13 ` Jeff Garzik
2006-08-10 20:27 ` Andrew Morton
2006-08-10 21:00 ` Jeff Garzik
2006-08-10 21:11 ` Alex Tomas
2006-08-10 22:18 ` [Ext2-devel] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810164832.GA305@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).