From: Theodore Tso <tytso@mit.edu>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net,
cmm@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] extents for ext4
Date: Thu, 10 Aug 2006 13:17:55 -0400 [thread overview]
Message-ID: <20060810171755.GA19238@thunk.org> (raw)
In-Reply-To: <20060809233940.50162afb.akpm@osdl.org>
On Wed, Aug 09, 2006 at 11:39:40PM -0700, Andrew Morton wrote:
> - replace all brelse() calls with put_bh(). Because brelse() is
> old-fashioned, has a weird name and neelessly permits a NULL arg.
>
> In fact it would be beter to convert JBD and ext3 to put_bh before
> copying it all over.
Wouldn't it be better to preserve in the source code history the
brelse->put_bh conversion? We can pour a huge number of changes in
ext4 before we submit, but I would have thought it would be easier for
everyone to see what is going on if we submit with just the minimal
changes, and then have patches that address concerns like this one at
a time.
- Ted
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2006-08-10 17:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 1:20 [PATCH 1/9] extents for ext4 Mingming Cao
2006-08-10 6:39 ` Andrew Morton
2006-08-10 9:29 ` Alex Tomas
2006-08-10 9:48 ` Andrew Morton
2006-08-10 10:08 ` Alex Tomas
2006-08-10 15:55 ` Zach Brown
2006-08-10 17:49 ` [Ext2-devel] " Randy.Dunlap
2006-08-10 19:05 ` Alex Tomas
2006-08-11 20:57 ` Randy.Dunlap
2006-08-11 21:05 ` Alex Tomas
2006-08-11 21:49 ` [Ext2-devel] " Mingming Cao
2006-08-11 23:00 ` Andrew Morton
2006-08-12 6:02 ` [Ext2-devel] " Randy.Dunlap
2006-08-12 17:43 ` Darrick J. Wong
2006-08-12 18:20 ` Randy.Dunlap
2006-08-14 16:26 ` [Ext2-devel] " Mingming Cao
2006-08-14 17:22 ` Randy.Dunlap
2006-08-14 17:52 ` [Ext2-devel] " Jeff Garzik
2006-08-14 18:05 ` Randy.Dunlap
2006-08-14 18:13 ` Jeff Garzik
2006-08-15 15:40 ` [Ext2-devel] " Pavel Machek
2006-08-18 13:08 ` Andreas Dilger
2006-08-10 16:46 ` Mingming Cao
2006-08-10 17:17 ` Theodore Tso [this message]
2006-08-10 18:00 ` Andrew Morton
2006-08-11 22:13 ` Mingming Cao
2006-08-11 23:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810171755.GA19238@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).