linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: Josh Boyer <jwboyer@gmail.com>,
	torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/4] Use 64-bit inode numbers internally in the kernel
Date: Tue, 15 Aug 2006 10:13:58 +0100	[thread overview]
Message-ID: <20060815091358.GW29920@ftp.linux.org.uk> (raw)
In-Reply-To: <7329.1155630113@warthog.cambridge.redhat.com>

On Tue, Aug 15, 2006 at 09:21:53AM +0100, David Howells wrote:
> Josh Boyer <jwboyer@gmail.com> wrote:
> 
> > Out of curiosity, is there a performance hit for 32-bit systems?  Have
> > you done any minimal benchmarks to see?
> 
> Yes, I'm sure there is, but we're talking performance vs correctness.

ITYM performance vs. slightly different patch.  Let me put all pieces
in one place:
	* kstat gets u64 ino
	* filesystems that want to report 64bit st_ino do it in their
->getattr(); the rest is unchanged.
	* ino_t is left as-is
	* filldir() callbacks get u64 ino in arguments.  Filesystem may
pass 64bit value if it cares to; otherwise it's left unchanged.
	* filesystem that wants unusual search key can use iget5() (as
it can do right now)
	* filesystem that wants to use the values it'd put into st_ino in
its printks should use appropriate format
	* any printk in generic code that happens to use i_ino should
be hunted down and shot for utter uselessness for too many filesystems
(not sure if we actually _have_ any such printk these days).

      parent reply	other threads:[~2006-08-15  9:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <625fc13d0608141736q50dea86dh94cdf4ef19fe56d9@mail.gmail.com>
     [not found] ` <20060814211504.27190.10491.stgit@warthog.cambridge.redhat.com>
     [not found]   ` <20060814211509.27190.51352.stgit@warthog.cambridge.redhat.com>
2006-08-15  1:31     ` [RHEL5 PATCH 2/4] VFS: Make inode numbers 64-bits Al Viro
2006-08-15  8:21     ` David Howells
2006-08-15  9:06       ` Al Viro
2006-08-15  8:32     ` David Howells
2006-08-15  9:02       ` Al Viro
2006-08-15  9:25       ` David Howells
2006-08-15 12:45         ` Stephen Rothwell
     [not found]   ` <7329.1155630113@warthog.cambridge.redhat.com>
2006-08-15  9:13     ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060815091358.GW29920@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=dhowells@redhat.com \
    --cc=jwboyer@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).