linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Alex Tomas <alex@clusterfs.com>, Andrew Morton <akpm@osdl.org>,
	cmm@us.ibm.com, linux-fsdevel@vger.kernel.org,
	ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Ext2-devel] [PATCH 1/9] extents for ext4
Date: Tue, 15 Aug 2006 15:40:19 +0000	[thread overview]
Message-ID: <20060815154019.GD4032@ucw.cz> (raw)
In-Reply-To: <20060811135737.1abfa0f6.rdunlap@xenotime.net>

Hi!

> >  AM> - The existing comments could benefit from some rework by a
> >  AM> native English speaker.
> > 
> > could someone assist here, please?
> 
> See if this helps.
> Patch applies on top of all ext4 patches from
> http://ext2.sourceforge.net/48bitext3/patches/latest/.

> --- linux-2618-rc4-ext4.orig/include/linux/ext4_fs_extents.h
> +++ linux-2618-rc4-ext4/include/linux/ext4_fs_extents.h
> @@ -22,29 +22,29 @@
>  #include <linux/ext4_fs.h>
>  
>  /*
> - * with AGRESSIVE_TEST defined capacity of index/leaf blocks
> - * become very little, so index split, in-depth growing and
> - * other hard changes happens much more often
> - * this is for debug purposes only
> + * With AGRESSIVE_TEST defined, the capacity of index/leaf blocks
> + * becomes very small, so index split, in-depth growing and
> + * other hard changes happen much more often.
> + * This is for debug purposes only.
>   */
>  #define AGRESSIVE_TEST_

Using _ for disabling is unusual/nasty. Can't we simply #undef it?
-- 
Thanks for all the (sleeping) penguins.

  parent reply	other threads:[~2006-08-15 18:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-10  1:20 [PATCH 1/9] extents for ext4 Mingming Cao
2006-08-10  6:39 ` Andrew Morton
2006-08-10  9:29   ` Alex Tomas
2006-08-10  9:48     ` Andrew Morton
2006-08-10 10:08       ` Alex Tomas
2006-08-10 15:55       ` Zach Brown
2006-08-10 17:49     ` [Ext2-devel] " Randy.Dunlap
2006-08-10 19:05       ` Alex Tomas
2006-08-11 20:57     ` Randy.Dunlap
2006-08-11 21:05       ` Alex Tomas
2006-08-11 21:49       ` [Ext2-devel] " Mingming Cao
2006-08-11 23:00       ` Andrew Morton
2006-08-12  6:02         ` [Ext2-devel] " Randy.Dunlap
2006-08-12 17:43           ` Darrick J. Wong
2006-08-12 18:20             ` Randy.Dunlap
2006-08-14 16:26               ` [Ext2-devel] " Mingming Cao
2006-08-14 17:22                 ` Randy.Dunlap
2006-08-14 17:52                   ` [Ext2-devel] " Jeff Garzik
2006-08-14 18:05                     ` Randy.Dunlap
2006-08-14 18:13                       ` Jeff Garzik
2006-08-15 15:40       ` Pavel Machek [this message]
2006-08-18 13:08         ` [Ext2-devel] " Andreas Dilger
2006-08-10 16:46   ` Mingming Cao
2006-08-10 17:17   ` Theodore Tso
2006-08-10 18:00     ` Andrew Morton
2006-08-11 22:13       ` Mingming Cao
2006-08-11 23:16         ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2006-08-15 21:27 [Ext2-devel] " Randy Dunlap
2006-08-15 23:19 ` Mingming Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060815154019.GD4032@ucw.cz \
    --to=pavel@suse.cz \
    --cc=akpm@osdl.org \
    --cc=alex@clusterfs.com \
    --cc=cmm@us.ibm.com \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).