From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/17] BLOCK: Stop fallback_migrate_page() from using page_has_buffers() [try #2]
Date: Fri, 25 Aug 2006 15:10:14 +0100 [thread overview]
Message-ID: <20060825141014.GD10659@infradead.org> (raw)
In-Reply-To: <20060824213258.21323.94502.stgit@warthog.cambridge.redhat.com>
On Thu, Aug 24, 2006 at 10:32:58PM +0100, David Howells wrote:
> From: David Howells <dhowells@redhat.com>
>
> Stop fallback_migrate_page() from using page_has_buffers() since that might not
> be available. Use PagePrivate() instead since that's more general.
We should document somewhere where to use which of those functions,
especially as they are currently 100% functionally identical.
Also if we ever get private data for anything but buffers these kinds of
checks in generic code will cause problems. Maybe we should just
kill the default fallback in this case?
next prev parent reply other threads:[~2006-08-25 14:10 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200608250023.20903.arnd@arndb.de>
2006-08-24 21:32 ` [PATCH 01/17] BLOCK: Move functions out of buffer code [try #2] David Howells
2006-08-24 21:32 ` [PATCH 02/17] BLOCK: Remove duplicate declaration of exit_io_context() " David Howells
2006-08-25 14:08 ` Christoph Hellwig
2006-08-24 21:32 ` [PATCH 03/17] BLOCK: Stop fallback_migrate_page() from using page_has_buffers() " David Howells
2006-08-25 14:10 ` Christoph Hellwig [this message]
2006-08-25 16:11 ` David Howells
2006-08-24 21:33 ` [PATCH 04/17] BLOCK: Separate the bounce buffering code from the highmem code " David Howells
2006-08-25 14:12 ` Christoph Hellwig
2006-08-24 21:33 ` [PATCH 05/17] BLOCK: Don't call block_sync_page() from AFS " David Howells
2006-08-25 14:13 ` Christoph Hellwig
2006-08-25 16:12 ` David Howells
2006-08-24 21:33 ` [PATCH 06/17] BLOCK: Move bdev_cache_init() declaration to headerfile " David Howells
2006-08-25 14:13 ` Christoph Hellwig
2006-08-24 21:33 ` [PATCH 07/17] BLOCK: Remove dependence on existence of blockdev_superblock " David Howells
2006-08-25 14:14 ` Christoph Hellwig
2006-08-24 21:33 ` [PATCH 08/17] BLOCK: Dissociate generic_writepages() from mpage stuff " David Howells
2006-08-25 14:16 ` Christoph Hellwig
2006-08-24 21:33 ` [PATCH 09/17] BLOCK: Move __invalidate_device() to block_dev.c " David Howells
2006-08-25 14:16 ` Christoph Hellwig
2006-08-24 21:33 ` [PATCH 10/17] BLOCK: Move the loop device ioctl compat stuff to the loop driver " David Howells
2006-08-25 9:27 ` David Howells
2006-08-25 11:01 ` David Howells
2006-08-24 21:33 ` [PATCH 11/17] BLOCK: Move common FS-specific ioctls to linux/fs.h " David Howells
2006-08-25 8:38 ` David Howells
2006-08-25 8:44 ` Arnd Bergmann
2006-08-24 21:33 ` [PATCH 12/17] BLOCK: Move the ReiserFS device ioctl compat stuff to the ReiserFS driver " David Howells
2006-08-24 21:33 ` [PATCH 13/17] BLOCK: Move the Ext2 device ioctl compat stuff to the Ext2 " David Howells
2006-08-24 21:33 ` [PATCH 14/17] BLOCK: Move the Ext3 device ioctl compat stuff to the Ext3 " David Howells
2006-08-24 21:33 ` [PATCH 15/17] BLOCK: Stop CIFS from using EXT2 ioctl numbers directly " David Howells
2006-08-24 21:41 ` Trond Myklebust
2006-08-25 8:12 ` David Howells
2006-08-24 21:33 ` [PATCH 16/17] BLOCK: Move the msdos device ioctl compat stuff to the msdos driver " David Howells
2006-08-24 21:33 ` [PATCH 17/17] BLOCK: Make it possible to disable the block layer " David Howells
2006-08-25 14:27 ` Christoph Hellwig
2006-08-25 14:52 ` Alexey Dobriyan
2006-08-25 16:23 ` David Howells
2006-08-29 11:51 ` Christoph Hellwig
2006-08-29 12:21 ` Stefan Richter
2006-08-29 12:23 ` David Howells
2006-08-29 12:25 ` Christoph Hellwig
2006-08-29 13:50 ` Stefan Richter
2006-08-29 14:13 ` Stefan Richter
2006-08-30 1:12 ` Roman Zippel
2006-08-30 18:33 ` Stefan Richter
2006-08-30 21:43 ` Adrian Bunk
2006-08-30 22:41 ` Roman Zippel
2006-08-30 23:38 ` Adrian Bunk
2006-08-30 23:58 ` Roman Zippel
2006-08-31 8:01 ` Stefan Richter
2006-09-01 0:15 ` David Woodhouse
2006-09-01 0:48 ` Randy.Dunlap
2006-09-01 1:27 ` David Woodhouse
2006-09-01 1:47 ` Adrian Bunk
2006-09-01 13:44 ` Jörn Engel
2006-09-01 15:31 ` Stefan Richter
2006-09-01 16:19 ` Jörn Engel
2006-09-01 16:34 ` Adrian Bunk
2006-09-01 17:51 ` Stefan Richter
2006-09-01 18:14 ` Sam Ravnborg
2006-08-30 22:50 ` Stefan Richter
2006-08-30 23:12 ` Adrian Bunk
2006-08-30 1:11 ` Roman Zippel
2006-08-30 11:29 ` Stefan Richter
2006-08-29 19:58 ` Greg KH
2006-08-29 21:08 ` John Stoffel
2006-08-31 3:01 ` Matthew Wilcox
2006-08-31 3:04 ` Shaya Potter
2006-08-31 8:53 ` Stefan Richter
2006-08-31 12:32 ` Shaya Potter
2006-08-31 13:16 ` Stefan Richter
2006-08-31 13:27 ` Shaya Potter
2006-08-31 10:13 ` David Howells
2006-08-25 18:46 ` David Howells
2006-08-25 14:08 ` [PATCH 01/17] BLOCK: Move functions out of buffer code " Christoph Hellwig
[not found] <200608251217.24543.arnd@arndb.de>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060825141014.GD10659@infradead.org \
--to=hch@infradead.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).