From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 03/17] BLOCK: Stop fallback_migrate_page() from using page_has_buffers() [try #2]
Date: Fri, 25 Aug 2006 15:10:14 +0100
Message-ID: <20060825141014.GD10659@infradead.org>
References: <20060824213252.21323.18226.stgit@warthog.cambridge.redhat.com> <20060824213258.21323.94502.stgit@warthog.cambridge.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:7882 "EHLO
	pentafluge.infradead.org") by vger.kernel.org with ESMTP
	id S1751171AbWHYOKP (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 25 Aug 2006 10:10:15 -0400
To: David Howells <dhowells@redhat.com>
Content-Disposition: inline
In-Reply-To: <20060824213258.21323.94502.stgit@warthog.cambridge.redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, Aug 24, 2006 at 10:32:58PM +0100, David Howells wrote:
> From: David Howells <dhowells@redhat.com>
> 
> Stop fallback_migrate_page() from using page_has_buffers() since that might not
> be available.  Use PagePrivate() instead since that's more general.

We should document somewhere where to use which of those functions,
especially as they are currently 100% functionally identical.

Also if we ever get private data for anything but buffers these kinds of
checks in generic code will cause problems.  Maybe we should just
kill the default fallback in this case?