From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 05/17] BLOCK: Don't call block_sync_page() from AFS [try #2] Date: Fri, 25 Aug 2006 15:13:11 +0100 Message-ID: <20060825141311.GF10659@infradead.org> References: <20060824213252.21323.18226.stgit@warthog.cambridge.redhat.com> <20060824213303.21323.78091.stgit@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:13258 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751364AbWHYONc (ORCPT ); Fri, 25 Aug 2006 10:13:32 -0400 To: David Howells Content-Disposition: inline In-Reply-To: <20060824213303.21323.78091.stgit@warthog.cambridge.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > diff --git a/fs/afs/file.c b/fs/afs/file.c > index 67d6634..e1ba855 100644 > --- a/fs/afs/file.c > +++ b/fs/afs/file.c > @@ -37,7 +37,7 @@ struct inode_operations afs_file_inode_o > > const struct address_space_operations afs_fs_aops = { > .readpage = afs_file_readpage, > - .sync_page = block_sync_page, > +// .sync_page = block_sync_page, commenting out thing using // isn't very nice. Either remove it completely or use #if 0 with a normal /* */ that describes why it's not compiled.