From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 06/17] BLOCK: Move bdev_cache_init() declaration to headerfile [try #2] Date: Fri, 25 Aug 2006 15:13:47 +0100 Message-ID: <20060825141347.GG10659@infradead.org> References: <20060824213252.21323.18226.stgit@warthog.cambridge.redhat.com> <20060824213305.21323.66404.stgit@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:14794 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751434AbWHYONs (ORCPT ); Fri, 25 Aug 2006 10:13:48 -0400 To: David Howells Content-Disposition: inline In-Reply-To: <20060824213305.21323.66404.stgit@warthog.cambridge.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Aug 24, 2006 at 10:33:06PM +0100, David Howells wrote: > From: David Howells > > Move the bdev_cache_init() extern declaration from fs/dcache.c to > linux/blkdev.h. > > Signed-Off-By: David Howells > --- > > fs/dcache.c | 2 +- > include/linux/blkdev.h | 1 + > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/fs/dcache.c b/fs/dcache.c > index 1b4a3a3..886ca6f 100644 > --- a/fs/dcache.c > +++ b/fs/dcache.c > @@ -32,6 +32,7 @@ #include > #include > #include > #include > +#include > > > int sysctl_vfs_cache_pressure __read_mostly = 100; > @@ -1742,7 +1743,6 @@ kmem_cache_t *filp_cachep __read_mostly; > > EXPORT_SYMBOL(d_genocide); > > -extern void bdev_cache_init(void); > extern void chrdev_init(void); please move chrdev_init aswell while you're at it. Otherwise ok.