linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: axboe@kernel.dk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	dhowells@redhat.com
Subject: [PATCH 07/18] [PATCH] BLOCK: Remove dependence on existence of blockdev_superblock [try #3]
Date: Fri, 25 Aug 2006 15:49:31 +0100	[thread overview]
Message-ID: <20060825144931.30722.43302.stgit@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060825144916.30722.90944.stgit@warthog.cambridge.redhat.com>

From: David Howells <dhowells@redhat.com>

Move blockdev_superblock extern declaration from fs/fs-writeback.c to a
headerfile and remove the dependence on it by wrapping it in a macro.

Signed-Off-By: David Howells <dhowells@redhat.com>
---

 fs/fs-writeback.c      |    8 +++-----
 include/linux/blkdev.h |    4 ++++
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 892643d..d9de186 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -23,8 +23,6 @@ #include <linux/blkdev.h>
 #include <linux/backing-dev.h>
 #include <linux/buffer_head.h>
 
-extern struct super_block *blockdev_superblock;
-
 /**
  *	__mark_inode_dirty -	internal function
  *	@inode: inode to mark
@@ -320,7 +318,7 @@ sync_sb_inodes(struct super_block *sb, s
 
 		if (!bdi_cap_writeback_dirty(bdi)) {
 			list_move(&inode->i_list, &sb->s_dirty);
-			if (sb == blockdev_superblock) {
+			if (sb_is_blkdev_sb(sb)) {
 				/*
 				 * Dirty memory-backed blockdev: the ramdisk
 				 * driver does this.  Skip just this inode
@@ -337,14 +335,14 @@ sync_sb_inodes(struct super_block *sb, s
 
 		if (wbc->nonblocking && bdi_write_congested(bdi)) {
 			wbc->encountered_congestion = 1;
-			if (sb != blockdev_superblock)
+			if (!sb_is_blkdev_sb(sb))
 				break;		/* Skip a congested fs */
 			list_move(&inode->i_list, &sb->s_dirty);
 			continue;		/* Skip a congested blockdev */
 		}
 
 		if (wbc->bdi && bdi != wbc->bdi) {
-			if (sb != blockdev_superblock)
+			if (!sb_is_blkdev_sb(sb))
 				break;		/* fs has the wrong queue */
 			list_move(&inode->i_list, &sb->s_dirty);
 			continue;		/* blockdev has wrong queue */
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 04a11f7..311538e 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -16,6 +16,10 @@ #include <linux/stringify.h>
 
 #include <asm/scatterlist.h>
 
+extern struct super_block *blockdev_superblock;
+
+#define sb_is_blkdev_sb(sb) ((sb) == blockdev_superblock)
+
 struct scsi_ioctl_command;
 
 struct request_queue;

  parent reply	other threads:[~2006-08-25 14:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-25 14:49 [PATCH 00/18] BLOCK: Permit block layer to be disabled [try #3] David Howells
2006-08-25 14:49 ` [PATCH 01/18] [PATCH] BLOCK: Move functions out of buffer code " David Howells
2006-08-25 14:49 ` [PATCH 02/18] [PATCH] BLOCK: Remove duplicate declaration of exit_io_context() " David Howells
2006-08-25 14:49 ` [PATCH 03/18] [PATCH] BLOCK: Stop fallback_migrate_page() from using page_has_buffers() " David Howells
2006-08-25 14:49 ` [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code " David Howells
2006-08-25 14:49 ` [PATCH 05/18] [PATCH] BLOCK: Don't call block_sync_page() from AFS " David Howells
2006-08-25 14:49 ` [PATCH 06/18] [PATCH] BLOCK: Move bdev_cache_init() declaration to headerfile " David Howells
2006-08-25 14:49 ` David Howells [this message]
2006-08-25 14:49 ` [PATCH 08/18] [PATCH] BLOCK: Dissociate generic_writepages() from mpage stuff " David Howells
2006-08-25 14:49 ` [PATCH 09/18] [PATCH] BLOCK: Move __invalidate_device() to block_dev.c " David Howells
2006-08-25 14:49 ` [PATCH 10/18] [PATCH] BLOCK: Move the loop device ioctl compat stuff to the loop driver " David Howells
2006-08-25 14:49 ` [PATCH 11/18] [PATCH] BLOCK: Move common FS-specific ioctls to linux/fs.h " David Howells
2006-08-25 14:49 ` [PATCH 12/18] [PATCH] BLOCK: Move the ReiserFS device ioctl compat stuff to the ReiserFS driver " David Howells
2006-08-25 14:49 ` [PATCH 13/18] [PATCH] BLOCK: Move the Ext2 device ioctl compat stuff to the Ext2 " David Howells
2006-08-25 14:49 ` [PATCH 14/18] [PATCH] BLOCK: Move the Ext3 device ioctl compat stuff to the Ext3 " David Howells
2006-08-25 14:49 ` [PATCH 15/18] [PATCH] BLOCK: Move the msdos device ioctl compat stuff to the msdos " David Howells
2006-08-25 14:49 ` [PATCH 16/18] [PATCH] BLOCK: Remove no-longer necessary linux/mpage.h inclusions " David Howells
2006-08-25 14:49 ` [PATCH 17/18] [PATCH] BLOCK: Remove no-longer necessary linux/buffer_head.h " David Howells
2006-08-25 14:49 ` [PATCH 18/18] [PATCH] BLOCK: Make it possible to disable the block layer " David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060825144931.30722.43302.stgit@warthog.cambridge.redhat.com \
    --to=dhowells@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).