From: Al Viro <viro@ftp.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Josef Sipek <jsipek@fsl.cs.sunysb.edu>,
linux-kernel@vger.kernel.org, notting@redhat.com,
torvalds@osdl.org, hch@infradead.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Introduce vfs_listxattr
Date: Mon, 9 Oct 2006 21:42:13 +0100 [thread overview]
Message-ID: <20061009204213.GZ29920@ftp.linux.org.uk> (raw)
In-Reply-To: <20061009133332.5c8285ce.akpm@osdl.org>
On Mon, Oct 09, 2006 at 01:33:32PM -0700, Andrew Morton wrote:
> On Mon, 9 Oct 2006 16:10:48 -0400
> Josef Sipek <jsipek@fsl.cs.sunysb.edu> wrote:
>
> > This patch moves code out of fs/xattr.c:listxattr into a new function -
> > vfs_listxattr. The code for vfs_listxattr was originally submitted by Bill
> > Nottingham <notting@redhat.com> to Unionfs.
>
> That tells us what the patch does. In general, please be sure to also tell
> us *why* you prepared a patch.
>
> Does this patch allow unionfs to be loaded into an otherwise unpatched
> kernel.org kernel? If so, that seems to be a good reason for including
> this patch into the mainline kernel.
Generally I'd say that it makes sense. Anything that wants to
access the method in question would either have to play with
set_fs() or open-code it; neither is good.
It makes sense to localize calls of a method when we have pretty
much mandatory framing for it (security_... stuff).
So the only question is whether it makes sense for anything other
than syscall itself to access the method in question. AFAICS,
the answer's yes...
next prev parent reply other threads:[~2006-10-09 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 20:10 [PATCH] Introduce vfs_listxattr Josef Sipek
2006-10-09 20:33 ` Andrew Morton
2006-10-09 20:42 ` Al Viro [this message]
2006-10-09 20:46 ` Josef Sipek
2006-10-09 20:39 ` Al Viro
2006-10-10 13:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061009204213.GZ29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notting@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).