From: Mark Fasheh <mark.fasheh@oracle.com>
To: linux-fsdevel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>, Jens Axboe <jens.axboe@oracle.com>
Subject: i_mutex locking in generic_file_splice_write()
Date: Thu, 12 Oct 2006 12:01:52 -0700 [thread overview]
Message-ID: <20061012190152.GU6485@ca-server1.us.oracle.com> (raw)
Hi,
generic_file_splice_write() will call into a file systems
->prepare_write() and ->commit_write() via the the pipe_to_file() actor.
pipe_to_file() is careful to take the pipe inode i_mutex, but nowhere in the
call path do I see i_mutex on the inode being written to taken.
Shouldn't we be taking this before calling into ->prepare_write() and
->commit_write(). What's preventing generic_file_splice_write() from racing
a truncate? Or maybe even another write?
A quick look through other callers reveals that generic_file_aio_write() and
do_lo_send_aops() both are careful to take i_mutex.
Thanks,
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
next reply other threads:[~2006-10-12 19:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 19:01 Mark Fasheh [this message]
2006-10-12 19:54 ` i_mutex locking in generic_file_splice_write() Andrew Morton
2006-10-13 0:17 ` Mark Fasheh
2006-10-13 7:45 ` Jens Axboe
2006-10-13 8:11 ` Andrew Morton
2006-10-13 8:18 ` Jens Axboe
2006-10-13 19:44 ` Mark Fasheh
2006-10-15 18:05 ` Jens Axboe
2006-10-15 19:56 ` Mark Fasheh
2006-10-15 20:08 ` Jens Axboe
2006-10-15 20:14 ` Mark Fasheh
2006-10-16 17:58 ` Andreas Dilger
2006-10-16 22:24 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012190152.GU6485@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=akpm@osdl.org \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).