From: Andrew Morton <akpm@osdl.org>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
hch@infradead.org, viro@ftp.linux.org.uk,
linux-fsdevel@vger.kernel.org, penberg@cs.helsinki.fi,
ezk@cs.sunysb.edu, mhalcrow@us.ibm.com
Subject: Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*
Date: Fri, 13 Oct 2006 13:37:22 -0700 [thread overview]
Message-ID: <20061013133722.d4f33ecb.akpm@osdl.org> (raw)
In-Reply-To: <20061013200705.GB31928@filer.fsl.cs.sunysb.edu>
On Fri, 13 Oct 2006 16:07:05 -0400
Josef Sipek <jsipek@fsl.cs.sunysb.edu> wrote:
> > > +static inline void __stackfs_copy_attr_all(struct inode *dest,
> > > + const struct inode *src,
> > > + int (*get_nlinks)(struct inode *))
> > > +{
> > > + if (!get_nlinks)
> > > + dest->i_nlink = src->i_nlink;
> > > + else
> > > + dest->i_nlink = get_nlinks(dest);
> >
> > I cannot find a get_nlinks() in 2.6.19-rc2?
>
> It is the last argument to the function. Perhaps the function name is
> deceiving.
doh.
That's why us old farts like to see
dest->i_nlink = (*get_nlinks)(dest);
next prev parent reply other threads:[~2006-10-13 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 11:18 [PATCH 0 of 2] Stackfs: generic stackable filesystem helper functions Josef Jeff Sipek
2006-10-13 11:18 ` [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_* Josef Jeff Sipek
2006-10-13 19:04 ` Andrew James Wade
2006-10-15 17:38 ` [PATCH] " Jan Engelhardt
2006-10-13 19:27 ` Andrew Morton
2006-10-13 20:07 ` Josef Sipek
2006-10-13 20:16 ` Josef Sipek
2006-10-13 20:37 ` Andrew Morton [this message]
2006-10-15 12:36 ` Jan Engelhardt
2006-10-13 11:18 ` [PATCH 2 of 2] eCryptfs: Use stackfs's generic copy inode attr functions Josef Jeff Sipek
2006-10-13 12:02 ` [PATCH 0 of 2] Stackfs: generic stackable filesystem helper functions Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061013133722.d4f33ecb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ezk@cs.sunysb.edu \
--cc=hch@infradead.org \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).