linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@suse.de>
To: linux-fsdevel@vger.kernel.org
Subject: [rfc] changing commit_write to commit less than was prepared
Date: Sun, 15 Oct 2006 16:45:28 +0200	[thread overview]
Message-ID: <20061015144528.GD25243@wotan.suse.de> (raw)

Hi,

In recently trying to solve the several (longstanding) deadlocks in
write(2), I developed what I believe to be the best solution. This
requires that ->commit_write may be called with a length less than
that which was passed to the prepare_write. If the length is different,
it may be 0, and for !uptodate pages it will only be 0. There is no
guarantee that the commit_write will ever be called later to fill the
gap.

I have gone through fs/libfs.c and fs/buffer.c, and not found any
problems (apart from pre-existing bugs). I will attempt to work my way
through other filesystems, but I could easily miss problems.

This problem is now holding up other mm/ race fixes, so it is a question
of when, not if. So filesystem maintainers, please check your code and
fix it if broken, or come up with a better solution ;)

Apologies for not cc'ing linux-fsdevel in the first place. Please join
the thread on lkml and linux-mm: "[rfc] buffered write deadlock fix"
message id 20061013143516.15438.8802.sendpatchset@linux.site

and please cc me.

Thanks,
Nick


                 reply	other threads:[~2006-10-15 14:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061015144528.GD25243@wotan.suse.de \
    --to=npiggin@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).