From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Waitz Subject: Re: [PATCH 01 of 23] VFS: change struct file to use struct path Date: Mon, 23 Oct 2006 13:47:36 +0200 Message-ID: <20061023114736.GA15167@admingilde.org> References: <20061021002200.4731cdeb.akpm@osdl.org> <20061021072807.GF30620@filer.fsl.cs.sunysb.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, torvalds@osdl.org, viro@ftp.linux.org.uk, hch@infradead.org, jack@suse.cz Return-path: Received: from agent.admingilde.org ([213.95.21.5]:61674 "EHLO mail.admingilde.org") by vger.kernel.org with ESMTP id S932129AbWJWLrx (ORCPT ); Mon, 23 Oct 2006 07:47:53 -0400 To: Josef Sipek Content-Disposition: inline In-Reply-To: <20061021072807.GF30620@filer.fsl.cs.sunysb.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable hoi :) On Sat, Oct 21, 2006 at 03:28:07AM -0400, Josef Sipek wrote: > > why? >=20 > It's little cleaner than having two pointers. In general, there is a numb= er > of users of dentry-vfsmount pairs in the kernel, and struct path nicely > wraps it. Sure, but you can split the patch up: First, change struct file and introduce the #defines so that everything still works as before. If this is accepted upstream, you can start to move other kernel code to use the new names. If all active trees have finally moved to only use the new name, then you can remove the #define. --=20 Martin Waitz --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFFPKvYj/Eaxd/oD7IRAi3zAJ9qSZFesBjkZrGY7oji3jOwz4QLmACfb4wV M0NkF7IKaZtHjtr+0RJAlPY= =X3Lv -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--