From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [RFC PATCH 0/2] O_DIRECT locking rework Date: Tue, 24 Oct 2006 18:22:07 -0400 Message-ID: <20061024222207.GK12815@think.oraclecorp.com> References: <20061020183237.GA8674@think.oraclecorp.com> <20061024193435.GE12815@think.oraclecorp.com> <1161721711.18096.33.camel@dyn9047017100.beaverton.ibm.com> <20061024205024.GJ12815@think.oraclecorp.com> <1161726723.28727.0.camel@dyn9047017100.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel , akpm@osdl.org, Zach Brown Return-path: Received: from agminet01.oracle.com ([141.146.126.228]:58843 "EHLO agminet01.oracle.com") by vger.kernel.org with ESMTP id S1422732AbWJXWWS (ORCPT ); Tue, 24 Oct 2006 18:22:18 -0400 To: Badari Pulavarty Content-Disposition: inline In-Reply-To: <1161726723.28727.0.camel@dyn9047017100.beaverton.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Oct 24, 2006 at 02:52:03PM -0700, Badari Pulavarty wrote: > > > > Thanks, I missed an i_mutex change. Let me audit mutexes coming in and > > out again and resend. > > > > I think the new rules should be: > > > > reads: don't need i_mutex at all > > writes: don't need i_mutex for io inside i_size. > > > > Oh, and don't mess with i_mutex under DIO_OWN_LOCKING. > > No problem. > > I ran into one more nasty looking bug .. Neat. Which fsx command line did you use? -chris