From: Christoph Hellwig <hch@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
Steven Whitehouse <swhiteho@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] GFS2: incorrect di_height assignment
Date: Thu, 2 Nov 2006 10:59:36 +0000 [thread overview]
Message-ID: <20061102105936.GB714@infradead.org> (raw)
In-Reply-To: <20061102034556.GB4899@martell.zuzino.mipt.ru>
On Thu, Nov 02, 2006 at 06:45:56AM +0300, Alexey Dobriyan wrote:
> Harmless, but needed for endian-clean GFS2.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> fs/gfs2/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -691,7 +691,7 @@ static void init_dinode(struct gfs2_inod
>
> di->__pad1 = 0;
> di->di_payload_format = cpu_to_be32(0);
> - di->di_height = cpu_to_be32(0);
> + di->di_height = cpu_to_be16(0);
you are allowed to directly assign 0 to __be* variables.
next prev parent reply other threads:[~2006-11-02 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 3:45 [PATCH] GFS2: incorrect di_height assignment Alexey Dobriyan
2006-11-02 10:59 ` Christoph Hellwig [this message]
2006-11-02 12:12 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061102105936.GB714@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).