From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] GFS2: incorrect di_height assignment
Date: Thu, 2 Nov 2006 10:59:36 +0000
Message-ID: <20061102105936.GB714@infradead.org>
References: <20061102034556.GB4899@martell.zuzino.mipt.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Morton <akpm@osdl.org>,
	Steven Whitehouse <swhiteho@redhat.com>,
	linux-fsdevel@vger.kernel.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:44967 "EHLO
	pentafluge.infradead.org") by vger.kernel.org with ESMTP
	id S1752825AbWKBK7k (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 2 Nov 2006 05:59:40 -0500
To: Alexey Dobriyan <adobriyan@gmail.com>
Content-Disposition: inline
In-Reply-To: <20061102034556.GB4899@martell.zuzino.mipt.ru>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, Nov 02, 2006 at 06:45:56AM +0300, Alexey Dobriyan wrote:
> Harmless, but needed for endian-clean GFS2.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  fs/gfs2/inode.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -691,7 +691,7 @@ static void init_dinode(struct gfs2_inod
>  
>  	di->__pad1 = 0;
>  	di->di_payload_format = cpu_to_be32(0);
> -	di->di_height = cpu_to_be32(0);
> +	di->di_height = cpu_to_be16(0);

you are allowed to directly assign 0 to __be* variables.