From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make last_inode counter in new_inode 32-bit on kernels that offer x86 compatability
Date: Mon, 6 Nov 2006 21:23:13 +0100 [thread overview]
Message-ID: <20061106202313.GA691@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <1162838843.12129.8.camel@dantu.rdu.redhat.com>
On Mon, 6 November 2006 13:47:23 -0500, Jeff Layton wrote:
> On Mon, 2006-11-06 at 11:22 -0700, Matthew Wilcox wrote:
> > On Mon, Nov 06, 2006 at 01:12:05PM -0500, Jeff Layton wrote:
> > > The attached patch remedies this by making the last_inode counter be an
> > > unsigned int on kernels that have ia32 compatability mode enabled.
> >
> > ... and this only happens on ia64/x86_64 kernels, not sparc64, ppc64,
> > s390x, parisc64 or mips64?
>
> Here's a new (untested) patch that replaces the ia32 specific
> compatability mode defines with CONFIG_COMPAT, as suggested by Matthew.
While you're at it, how about making last_ino per-sb instead of
system-wide? ino collisions after a wrap are just as bad as inos
beyond 32bit. And this should be a fairly simple method to reduce the
risk.
Also, do you have a testcase that can actually force the wrap?
Jörn
--
Don't patch bad code, rewrite it.
-- Kernigham and Pike, according to Rusty
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2006-11-06 20:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 18:12 [PATCH] make last_inode counter in new_inode 32-bit on kernels that offer x86 compatability Jeff Layton
2006-11-06 18:22 ` Matthew Wilcox
2006-11-06 18:31 ` Jeff Layton
2006-11-06 18:47 ` Jeff Layton
2006-11-06 20:23 ` Jörn Engel [this message]
2006-11-06 20:31 ` Eric Dumazet
2006-11-06 20:56 ` Jeff Layton
2006-11-06 20:50 ` Eric Sandeen
2006-11-06 21:11 ` Jörn Engel
2006-11-06 21:36 ` Eric Sandeen
2006-11-06 22:01 ` Andreas Dilger
2006-11-07 15:56 ` Jeff Layton
2006-11-07 16:07 ` Jeff Layton
2006-11-07 16:10 ` Matthew Wilcox
2006-11-07 17:04 ` Jörn Engel
2006-11-07 17:28 ` Jörn Engel
2006-11-07 17:42 ` Jörn Engel
2006-11-07 17:53 ` Dave Kleikamp
2006-11-07 18:07 ` Jörn Engel
2006-11-07 17:56 ` Jörn Engel
2006-11-07 18:01 ` Jörn Engel
2006-11-07 18:10 ` Eric Sandeen
2006-11-07 19:41 ` Jeff Layton
2006-11-07 20:41 ` Jörn Engel
2006-11-07 21:13 ` Jeff Layton
2006-11-07 21:20 ` Matthew Wilcox
2006-11-07 22:09 ` Jeff Layton
2006-11-07 18:01 ` Jeff Layton
2006-11-07 18:14 ` Jörn Engel
2006-11-07 18:23 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061106202313.GA691@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).