From: Andreas Dilger <adilger@clusterfs.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "J�rn Engel" <joern@wohnheim.fh-wedel.de>,
"Jeff Layton" <jlayton@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make last_inode counter in new_inode 32-bit on kernels that offer x86 compatability
Date: Mon, 6 Nov 2006 15:01:40 -0700 [thread overview]
Message-ID: <20061106220140.GD6012@schatzie.adilger.int> (raw)
In-Reply-To: <454FAAF8.8080707@redhat.com>
On Nov 06, 2006 15:36 -0600, Eric Sandeen wrote:
> OTOH if one filesystem (say, pipes) can wrap the numbers very quickly,
> while other spaces are otherwise more immune, then having it global puts
> everything using it at a bit more risk.
One option is having a per-sb counter (to avoid wraps on not-heavily-used
filesystems), and also a per-sb flag that indicates if the counter has
wrapped. If that happens, it would be possible to do a lookup in the
inode hash for a conflicting inode number, and skip those. It is more
overhead, but only hit in the case where there is danger (i.e. post wrap).
There should also be a flag indicating if the caller is actually using
the inum supplied by new_inode or not, to avoid the overhead if it just
replaces i_ino with its own value.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2006-11-06 22:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 18:12 [PATCH] make last_inode counter in new_inode 32-bit on kernels that offer x86 compatability Jeff Layton
2006-11-06 18:22 ` Matthew Wilcox
2006-11-06 18:31 ` Jeff Layton
2006-11-06 18:47 ` Jeff Layton
2006-11-06 20:23 ` Jörn Engel
2006-11-06 20:31 ` Eric Dumazet
2006-11-06 20:56 ` Jeff Layton
2006-11-06 20:50 ` Eric Sandeen
2006-11-06 21:11 ` Jörn Engel
2006-11-06 21:36 ` Eric Sandeen
2006-11-06 22:01 ` Andreas Dilger [this message]
2006-11-07 15:56 ` Jeff Layton
2006-11-07 16:07 ` Jeff Layton
2006-11-07 16:10 ` Matthew Wilcox
2006-11-07 17:04 ` Jörn Engel
2006-11-07 17:28 ` Jörn Engel
2006-11-07 17:42 ` Jörn Engel
2006-11-07 17:53 ` Dave Kleikamp
2006-11-07 18:07 ` Jörn Engel
2006-11-07 17:56 ` Jörn Engel
2006-11-07 18:01 ` Jörn Engel
2006-11-07 18:10 ` Eric Sandeen
2006-11-07 19:41 ` Jeff Layton
2006-11-07 20:41 ` Jörn Engel
2006-11-07 21:13 ` Jeff Layton
2006-11-07 21:20 ` Matthew Wilcox
2006-11-07 22:09 ` Jeff Layton
2006-11-07 18:01 ` Jeff Layton
2006-11-07 18:14 ` Jörn Engel
2006-11-07 18:23 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061106220140.GD6012@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=jlayton@redhat.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).