From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: [RFC] [PATCH 3/4] uid_ns: replace i_uid check in fs/namespace.c Date: Mon, 6 Nov 2006 22:20:07 -0600 Message-ID: <20061107042007.GD28706@sergelap.austin.ibm.com> References: <20061107041814.GA28706@sergelap.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from e2.ny.us.ibm.com ([32.97.182.142]:63444 "EHLO e2.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1753997AbWKGEUJ (ORCPT ); Mon, 6 Nov 2006 23:20:09 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e2.ny.us.ibm.com (8.13.8/8.12.11) with ESMTP id kA74K8O3006765 for ; Mon, 6 Nov 2006 23:20:08 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kA74K8DM114494 for ; Mon, 6 Nov 2006 23:20:08 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kA74K8OR006692 for ; Mon, 6 Nov 2006 23:20:08 -0500 To: Containers , linux-fsdevel@vger.kernel.org Content-Disposition: inline In-Reply-To: <20061107041814.GA28706@sergelap.austin.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Replace a inode->i_uid==current->fsuid check in fs/namespace.c with the inode_task_same_uid helper, which will eventually be checking uid namespaces. Signed-off-by: Serge E. Hallyn --- fs/namespace.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) bccafb526d224ae0c82c3370c0056eef5686bb4a diff --git a/fs/namespace.c b/fs/namespace.c index ec1a255..e199769 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -697,7 +697,7 @@ static int mount_is_safe(struct nameidat if (S_ISLNK(nd->dentry->d_inode->i_mode)) return -EPERM; if (nd->dentry->d_inode->i_mode & S_ISVTX) { - if (current->uid != nd->dentry->d_inode->i_uid) + if (!inode_task_same_uid(nd->dentry->d_inode, current)) return -EPERM; } /* -- 1.1.6