From: Al Viro <viro@ftp.linux.org.uk>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr)
Date: Tue, 14 Nov 2006 20:26:25 +0000 [thread overview]
Message-ID: <20061114202625.GY29920@ftp.linux.org.uk> (raw)
In-Reply-To: <1163535728.15846.21.camel@dantu.rdu.redhat.com>
On Tue, Nov 14, 2006 at 03:22:08PM -0500, Jeff Layton wrote:
> This patch is a first step at correcting these problems. It declares a
> new file_system_type flag (FS_I_INO_DYNAMIC). If this is set, then when
> new_inode is called, we'll use the IDR functions to generate a unique
> 31-bit value, leaving the first 100 inode numbers for statically
> allocated stuff like root inodes, etc. At inode deletion time, we
> idr_remove it so the i_ino value can be reused.
NAK. All calls of new_inode() are triggered from within fs code;
there's no reason to introduce flags (which should be the last
resort) when you bloody well can have a separate helpers for that
case and have them called. Explicitly.
next prev parent reply other threads:[~2006-11-14 20:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-14 20:22 [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr) Jeff Layton
2006-11-14 20:26 ` Al Viro [this message]
2006-11-15 16:42 ` Jeff Layton
2006-11-15 16:44 ` Jeff Layton
2006-11-16 14:06 ` Al Viro
2006-11-16 14:34 ` Jeff Layton
2006-11-15 17:27 ` Matthew Wilcox
2006-11-15 17:56 ` Jörn Engel
2006-11-15 20:36 ` Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2006-12-01 14:48 Jeff Layton
2006-12-01 16:52 ` Randy Dunlap
2006-12-01 17:21 ` Jeff Layton
2006-12-01 17:42 ` Randy Dunlap
2006-12-02 5:30 ` Brad Boyer
2006-12-03 2:56 ` Jeff Layton
2006-12-02 12:58 ` Brad Boyer
2006-12-03 11:52 ` Al Boldi
2006-12-03 12:49 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061114202625.GY29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).